Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importing tuples from JSON #13736

Merged
merged 1 commit into from Mar 28, 2024
Merged

Fix importing tuples from JSON #13736

merged 1 commit into from Mar 28, 2024

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Mar 28, 2024

Resolves #13724

This PR applies the sealed modifier to types loaded from ARM JSON only if additionalProperties was set to false in the source.

Microsoft Reviewers: Open in CodeFlow

…onalProperties` was set to `false` in the source
Copy link
Contributor

github-actions bot commented Mar 28, 2024

Test this change out locally with the following install scripts (Action run 8474150717)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 8474150717
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 8474150717"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 8474150717
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 8474150717"

Copy link
Contributor

Test Results

    66 files   -     33      66 suites   - 33   21m 57s ⏱️ - 15m 50s
10 722 tests  -     19  10 720 ✅  -     19  2 💤 ±0  0 ❌ ±0 
25 340 runs   - 12 663  25 336 ✅  - 12 661  4 💤  - 2  0 ❌ ±0 

Results for commit 1d0dc60. ± Comparison against base commit 6b0e259.

@jeskew jeskew merged commit fbb71ec into main Mar 28, 2024
44 checks passed
@jeskew jeskew deleted the jeskew/13724 branch March 28, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User-defined types not parsing array correctly when deploying from template spec
2 participants