Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importing tagged unions from compiled JSON #13733

Merged
merged 1 commit into from Mar 28, 2024
Merged

Fix importing tagged unions from compiled JSON #13733

merged 1 commit into from Mar 28, 2024

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Mar 28, 2024

Resolves #13726

This PR updates the import closure compiler to take account of ARM's discriminator constraint both for type declaration -> TypeExpression conversion and for reference collecting purposes.

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Mar 28, 2024

Test this change out locally with the following install scripts (Action run 8474148352)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 8474148352
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 8474148352"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 8474148352
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 8474148352"

Copy link
Contributor

github-actions bot commented Mar 28, 2024

Test Results

    65 files   -     34      65 suites   - 34   24m 3s ⏱️ - 13m 44s
10 722 tests  -     19  10 720 ✅  -     19  2 💤 ±0  0 ❌ ±0 
25 340 runs   - 12 663  25 336 ✅  - 12 661  4 💤  - 2  0 ❌ ±0 

Results for commit 855485d. ± Comparison against base commit 6b0e259.

♻️ This comment has been updated with latest results.

@jeskew jeskew merged commit 7860d23 into main Mar 28, 2024
86 checks passed
@jeskew jeskew deleted the jeskew/13726 branch March 28, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants