Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid running no-hardcoded-env-urls linter rule in .bicepparam files #13608

Merged
merged 1 commit into from Mar 13, 2024

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Mar 13, 2024

Raised under #13607. This doesn't address the ask for the environment() function, but does ensure we avoid surfacing a warning that can't be actioned.

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Mar 13, 2024

Test this change out locally with the following install scripts (Action run 8269022494)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 8269022494
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 8269022494"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 8269022494
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 8269022494"

Copy link
Contributor

Test Results

    66 files   -     33      66 suites   - 33   23m 25s ⏱️ - 16m 1s
10 681 tests  -     19  10 679 ✅  -     19  2 💤 ±0  0 ❌ ±0 
25 252 runs   - 12 619  25 248 ✅  - 12 617  4 💤  - 2  0 ❌ ±0 

Results for commit e1d3e98. ± Comparison against base commit 0c0394b.

@anthony-c-martin anthony-c-martin merged commit 213e8d7 into main Mar 13, 2024
44 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/13607 branch March 13, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants