Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve nullability when loading resource-derived type from ARM JSON template #13536

Merged
merged 1 commit into from Mar 5, 2024

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Mar 5, 2024

Resolves #13526

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Test this change out locally with the following install scripts (Action run 8163468825)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 8163468825
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 8163468825"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 8163468825
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 8163468825"

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Test Results

    66 files   -     33      66 suites   - 33   22m 36s ⏱️ - 21m 17s
10 678 tests  -     19  10 677 ✅  -     19  1 💤 ±0  0 ❌ ±0 
25 246 runs   - 12 616  25 244 ✅  - 12 615  2 💤  - 1  0 ❌ ±0 

Results for commit 7c51eff. ± Comparison against base commit b41394e.

@jeskew jeskew enabled auto-merge (squash) March 5, 2024 20:09
@jeskew jeskew merged commit 27a4913 into main Mar 5, 2024
44 checks passed
@jeskew jeskew deleted the jeskew/13526 branch March 5, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource-derived type parameter doesn't respect being nullable
2 participants