Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AzResourceTypeFactory cache key to take account of required flags #13535

Merged
merged 2 commits into from Mar 5, 2024

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Mar 5, 2024

Resolves #13534

The cache within AzResourceTypeFactory was using the serialized type as a key, but since the AZ resource types reuse types pretty aggressively, this was leading to values being cached with the wrong flag assignments (which are dependent on where in a resource a particular type is used). This PR updates the cache to use a compound key instead to keep these usages separate.

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Test this change out locally with the following install scripts (Action run 8159701342)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 8159701342
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 8159701342"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 8159701342
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 8159701342"

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Test Results

    65 files   -     34      65 suites   - 34   20m 21s ⏱️ - 20m 51s
10 672 tests  -     24  10 671 ✅  -     23  1 💤 ±0  0 ❌  - 1 
22 423 runs   - 15 436  22 421 ✅  - 15 434  2 💤  - 1  0 ❌  - 1 

Results for commit e02cbc9. ± Comparison against base commit 2dc234c.

♻️ This comment has been updated with latest results.

@jeskew jeskew enabled auto-merge (squash) March 5, 2024 16:19
@jeskew jeskew merged commit 14af56c into main Mar 5, 2024
44 checks passed
@jeskew jeskew deleted the jeskew/13534 branch March 5, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BCP036 reported as error rather than warning (preventing suppression)
2 participants