Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude lines that are tested in samples #389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

diondrapeck
Copy link
Member

@diondrapeck diondrapeck commented Sep 2, 2020

CodeCov by default only considers a line covered if it has a test in the tests/testthat folder, but we have samples that run daily which include functions/objects that aren't included in tests/testthat. Taking that into account will give us a more accurate code coverage number.

@codecov-commenter
Copy link

Codecov Report

Merging #389 into master will increase coverage by 10.38%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #389       +/-   ##
===========================================
+ Coverage    7.67%   18.05%   +10.38%     
===========================================
  Files          18       14        -4     
  Lines        1042      443      -599     
===========================================
  Hits           80       80               
+ Misses        962      363      -599     
Impacted Files Coverage Δ
R/run.R 0.00% <0.00%> (ø)
R/compute.R 0.00% <0.00%> (ø)
R/datasets.R 0.00% <0.00%> (ø)
R/keyvault.R 0.00% <0.00%> (ø)
R/workspace.R 0.00% <0.00%> (ø)
R/hyperdrive.R 0.00% <0.00%> (ø)
R/webservice.R 0.00% <0.00%> (ø)
R/webservice-aci.R 0.00% <0.00%> (ø)
R/webservice-local.R 0.00% <0.00%> (ø)
R/do_azureml_parallel.R 0.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38f1d7c...3d1949f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants