-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generating document translation SDK from typespec for both single and batch translation. #35298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added single document translation tests - sync and async. Fixed getsupportedformat tests- sync and async.
restoring dt client + models behavior
…alidated that sync and async test cases work except for 1 failure
…st recordings to assets repo
sdk/translation/azure-ai-translation-document/azure/ai/translation/document/_patch.py
Outdated
Show resolved
Hide resolved
sdk/translation/azure-ai-translation-document/azure/ai/translation/document/aio/_patch.py
Outdated
Show resolved
Hide resolved
sdk/translation/azure-ai-translation-document/azure/ai/translation/document/aio/_patch.py
Outdated
Show resolved
Hide resolved
sdk/translation/azure-ai-translation-document/azure/ai/translation/document/aio/_patch.py
Outdated
Show resolved
Hide resolved
sdk/translation/azure-ai-translation-document/azure/ai/translation/document/aio/_patch.py
Outdated
Show resolved
Hide resolved
sdk/translation/azure-ai-translation-document/tests/test_cancel_translation_async.py
Outdated
Show resolved
Hide resolved
…t removal of $, orderby and FileFormatType changes.
sdk/translation/azure-ai-translation-document/azure/ai/translation/document/_patch.py
Outdated
Show resolved
Hide resolved
… passing in Live and Record/playback mode, hence pushed recordings to assets repo and uupdated assets.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments on the changelog, also make sure you update your README.
...ranslation/azure-ai-translation-document/azure/ai/translation/document/_operations/_patch.py
Show resolved
Hide resolved
sdk/translation/azure-ai-translation-document/azure/ai/translation/document/_patch.py
Outdated
Show resolved
Hide resolved
sdk/translation/azure-ai-translation-document/azure/ai/translation/document/_patch.py
Outdated
Show resolved
Hide resolved
…ation/document/_patch.py and fixing references
...ation/azure-ai-translation-document/azure/ai/translation/document/_operations/_operations.py
Show resolved
Hide resolved
...ranslation/azure-ai-translation-document/azure/ai/translation/document/_operations/_patch.py
Show resolved
Hide resolved
sdk/translation/azure-ai-translation-document/azure/ai/translation/document/_patch.py
Outdated
Show resolved
Hide resolved
sdk/translation/azure-ai-translation-document/azure/ai/translation/document/_patch.py
Outdated
Show resolved
Hide resolved
run post-processing
API change check APIView has identified API level changes in this PR and created following API reviews. |
...ai-translation-document/samples/async_samples/sample_list_translations_with_filters_async.py
Outdated
Show resolved
Hide resolved
...-translation-document/samples/async_samples/sample_synchronous_document_translation_async.py
Outdated
Show resolved
Hide resolved
...-translation-document/samples/async_samples/sample_synchronous_document_translation_async.py
Outdated
Show resolved
Hide resolved
sdk/translation/azure-ai-translation-document/tests/test_supported_formats.py
Outdated
Show resolved
Hide resolved
sdk/translation/azure-ai-translation-document/azure/ai/translation/document/aio/_patch.py
Outdated
Show resolved
Hide resolved
sdk/translation/azure-ai-translation-document/azure/ai/translation/document/aio/_patch.py
Outdated
Show resolved
Hide resolved
sdk/translation/azure-ai-translation-document/samples/sample_single_document_translation.py
Outdated
Show resolved
Hide resolved
sdk/translation/azure-ai-translation-document/tsp-location.yaml
Outdated
Show resolved
Hide resolved
sdk/translation/azure-ai-translation-document/tests/test_translation_async.py
Show resolved
Hide resolved
catalinaperalta
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines