[Event Hubs] Geo DR - Preview v2 #43973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-redding
changed the title
|
TODO:
|
m-redding
requested review from
KrzysztofCwalina,
tg-msft and
jsquire
as code owners
jsquire
approved these changes
May 10, 2024
...thub/Azure.Messaging.EventHubs.Shared/src/BlobCheckpointStore/BlobCheckpointStoreInternal.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
We should change the type in the UpdateCheckpointAsync overload as well on L369.
sdk/eventhub/Azure.Messaging.EventHubs/src/Azure.Messaging.EventHubs.csproj
Outdated
Show resolved
Hide resolved
sdk/eventhub/Azure.Messaging.EventHubs/src/Processor/CheckpointPosition.cs
Outdated
Show resolved
Hide resolved
sdk/eventhub/Azure.Messaging.EventHubs/src/Processor/CheckpointPosition.cs
Outdated
Show resolved
Hide resolved
…ntStore/BlobCheckpointStoreInternal.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
…ntHubs.csproj Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
…tPosition.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
…tPosition.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
m-redding
merged commit ba8b316
into
Azure:eventhubs-geodr-preview-2
34 of 37 checks passed
jsquire
added a commit
to jsquire/azure-sdk-for-net
that referenced
this pull request
May 17, 2024
* primary changes * fix build * run scripts * fix unit tests * additional test tweaks * changelog * Update sdk/eventhub/Azure.Messaging.EventHubs.Shared/src/BlobCheckpointStore/BlobCheckpointStoreInternal.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/CHANGELOG.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Azure.Messaging.EventHubs.csproj Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Processor/CheckpointPosition.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Processor/CheckpointPosition.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * forgot to bring some things from the other preview pr --------- Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
jsquire
added a commit
that referenced
this pull request
May 17, 2024
* primary changes * fix build * run scripts * fix unit tests * additional test tweaks * changelog * Update sdk/eventhub/Azure.Messaging.EventHubs.Shared/src/BlobCheckpointStore/BlobCheckpointStoreInternal.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/CHANGELOG.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Azure.Messaging.EventHubs.csproj Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Processor/CheckpointPosition.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Update sdk/eventhub/Azure.Messaging.EventHubs/src/Processor/CheckpointPosition.cs Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * forgot to bring some things from the other preview pr --------- Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #39367
The concepts being updated here all relate to the Event Hubs service no longer accepting numeric values for offset. Offset needs to be treated an opaque string.
---An alternative approach can be found in:---
The primary changes in this PR are the following: