updating .NET templates and updating .NET model prompts #3615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assert that the build errors are unrelated to my changes, as the same thing is happening in other PRs, and it comes from a code path that I did not touch. |
khkh-ms
approved these changes
Mar 6, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@khkh-ms checking back on this. What's needed to get this one in? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
PR are now passing in the pipeline. I will do another try for the build. I will recommend that you get latest from v4.x into your branch if it is not working. |
mattchenderson
force-pushed
the
mattchenderson/netupdates
branch
from
753cfe5
to
8a6978e
Compare
|
@khkh-ms, I pushed a rebase, but still seems off, and I see the same happening for "current build" too. |
|
Thanks! I will run the failing tests locally today/tomorrow and fix the tests if needed. |
|
Any updates @khkh-ms ? |
mattchenderson
force-pushed
the
mattchenderson/netupdates
branch
from
35fe575
to
e8173ce
Compare
mattchenderson
force-pushed
the
mattchenderson/netupdates
branch
2 times, most recently
from
7e59306
to
560f9eb
Compare
|
This PR now removes a test, reintroduction of which is related to #3644 |
mattchenderson
force-pushed
the
mattchenderson/netupdates
branch
from
560f9eb
to
e9e1017
Compare
mattchenderson
requested review from
vrdmr,
Francisco-Gamino,
andystaples and
ejizba
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3603
Also cleans up some label inconsistency and leads with the isolated worker model in prompting.
Pull request checklist