Add get dtl VNet function #664
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francedot
requested review from
lucabol,
petehauge and
RogerBestMsft
as code owners
petehauge
reviewed
Jun 3, 2020
| [ValidateNotNullOrEmpty()] | ||
| $Lab, | ||
|
|
||
| [parameter(Mandatory=$false, ValueFromPipeline=$true, HelpMessage="If set, get the Expanded Resource from the std VNet object")] |
There was a problem hiding this comment.
Should this be a value from the pipeline? I think only the Lab would be brought in via the pipeline?
|
|
||
| if ($ExpandResource) { | ||
| foreach($dtlLabVNet in $dtlLabVNets) { | ||
| Get-AzureRmVirtualNetwork -ResourceGroupName $dtlLabVNet.ResourceGroupName -Name $dtlLabVNet.Name -ExpandResource $ExpandResource |
There was a problem hiding this comment.
If ExpandResource isn't passed in - does anything get returned from this commandlet? I would think we should have the Lab VNets always returned, and if ExpandResource is passed in, we can inject another property that contains the underlying VNet resource? There's an example for Getting VMs & Extended status in the library...
| -ApiVersion 2018-09-15 | ||
|
|
||
| if ($ExpandResource) { | ||
| foreach($dtlLabVNet in $dtlLabVNets) { |
There was a problem hiding this comment.
Can use a more PowerShell-like syntax here like $dtlLabVNets | ForEach-Object { .... }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get-AzDtlVirtualNetworks:
Gets the Microsoft.DevTestLab/labs/virtualnetworks object.
If ExpandResource is set, it gets the full Microsoft.Network/virtualNetworks with the ExpandResource:
e.g.
Get-AzDtlVirtualNetworks -Lab $dtlLab -ExpandResource 'subnets/ipConfigurations'gets the full subnets list along with the assigned NIC IPs.