Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Component] Prevent the use of ‘component’ commands in dev mode #1485

Merged
merged 1 commit into from Dec 7, 2016

Conversation

derekbekoe
Copy link
Member

And, Fix nightly build version patching as well

@mention-bot
Copy link

@derekbekoe, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zooba, @brendandburns, @tjprescott and @djyou to be potential reviewers.

@derekbekoe derekbekoe changed the title Prevent the use of ‘component’ commands in dev mode [Component] Prevent the use of ‘component’ commands in dev mode Dec 1, 2016
- Also, the dev versions have all command modules installed by default
- If the user really wants to install another module, from some unknown location, they can use pip directly
- * pip doesn’t support mixing editable packages with regular packages *
pip install --editable and pip install clash for namespace packages #3
pypa/pip#3

And, Fix nightly build version patching as well
@tjprescott
Copy link
Member

Does "dev mode" refer to installs via the nightly build? Does it refer to installs via "dev_setup.py" (my favorite!) ?

@derekbekoe
Copy link
Member Author

It's the 'dev_setup.py' (and Docker automated build) installs only.
Nightly builds have the date on the end of the version and in this change, I check for version.endswith('+dev')

Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbekoe derekbekoe merged commit 87539f9 into Azure:master Dec 7, 2016
@derekbekoe derekbekoe deleted the no-component-dev branch December 7, 2016 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants