Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 2024 01 01 preview unhide package and protected files #7569

Merged
merged 15 commits into from May 10, 2024

Conversation

jamesfan1
Copy link
Member

@jamesfan1 jamesfan1 commented May 1, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented May 1, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️nginx
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd nginx deployment configuration update cmd nginx deployment configuration update added parameter package
⚠️ 1006 - ParaAdd nginx deployment configuration update cmd nginx deployment configuration update added parameter protected_files

Copy link

Hi @jamesfan1,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented May 1, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented May 1, 2024

For more info about extension versioning, please refer to Extension version schema

…amesfan1/azure-cli-extensions into feature-2024-01-01-preview-stable-conf
@kairu-ms
Copy link
Contributor

kairu-ms commented May 7, 2024

Hi @jamesfan1, it seems the recording files is out of date. Please update test recording in live mode using the latest azure-cli.

Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls do as well.

Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your support

Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take the needed steps.

Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls take the needed steps

Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug fixes pls

Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing

Copy link

@MoazzemHossain-bot MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for supporting

@kairu-ms kairu-ms merged commit 3bfa3d7 into Azure:main May 10, 2024
15 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ nginx ] : https://dev.azure.com/azclitools/release/_build/results?buildId=156976&view=results

Copy link

@MoazzemHossain-bot MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need help

@jamesfan1 jamesfan1 mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants