Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up detection descriptions #10463

Merged
merged 10 commits into from
May 17, 2024
Merged

Clean up detection descriptions #10463

merged 10 commits into from
May 17, 2024

Conversation

h-kipple
Copy link

Required items, please complete

Change(s):

  • Updated multiple Description field for 125 analytics

Reason for Change(s):

  • Most changes are to remove unexpected newlines. Detections are using literal block scalars, but many descriptions seem to have been written for folded block scalars. Some typos and spelling fixed also.

Version Updated:

  • Yes

Testing Completed:

  • No - description changes only

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

hannah.oneill@cybercx.com.au added 2 commits May 10, 2024 11:24
@h-kipple
Copy link
Author

@microsoft-github-policy-service agree

@v-atulyadav v-atulyadav added Solution Solution specialty review needed Detection Detection specialty review needed labels May 10, 2024
@h-kipple h-kipple marked this pull request as ready for review May 12, 2024 21:35
@h-kipple h-kipple requested review from a team as code owners May 12, 2024 21:35
@h-kipple
Copy link
Author

Hi @v-shukore @v-atulyadav

The remaining pipeline failures are not a result of changes that I made. Can you please advise how to proceed?

v-shukore and others added 4 commits May 16, 2024 11:52
@v-shukore
Merge branch 'master' into pr/10463
f2c7462
@shainw
Update NewPAPCAPCASaddedtoADO.yaml
2696339 
Removing line in query that is breaking PR validation
@shainw
Update MaliciousWAFSessions.yaml
d4315c0 
Removing another line from the query that is causing the PR validation fail
@shainw
Update MaliciousWAFSessions.yaml
fb3b773 
Missed adjusting the ```| sort by``` line after removing timestamp.
@v-atulyadav v-atulyadav merged commit d87b207 into Azure:master May 17, 2024
32 checks passed
@v-shukore v-shukore mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-atulyadav v-atulyadav v-atulyadav approved these changes

@v-shukore v-shukore v-shukore approved these changes

Assignees

@v-shukore v-shukore

Labels
Detection Detection specialty review needed Solution Solution specialty review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@h-kipple @v-atulyadav @v-shukore @shainw