Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add functional tests for batch_push_results #873

Merged
merged 12 commits into from May 13, 2024

Conversation

cecheta
Copy link
Collaborator

@cecheta cecheta commented May 10, 2024

Purpose

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Run unit tests
  • Run functional tests
  • Deploy to Azure

What to Check

Verify that the following are valid

  • All tests passing
  • Admin + webapp working

Copy link

github-actions bot commented May 10, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/batch/utilities/helpers
   azure_blob_storage_client.py792963%19, 23–25, 33, 57–58, 61, 78–79, 81, 85, 141, 144, 163, 166, 168, 176–180, 203, 207–211, 213
   env_helper.py1251092%205, 210–211, 214–216, 225, 229–231
TOTAL229767570% 

Tests Skipped Failures Errors Time
178 0 💤 0 ❌ 0 🔥 11.325s ⏱️

@cecheta cecheta marked this pull request as draft May 10, 2024 14:24
@cecheta cecheta marked this pull request as ready for review May 10, 2024 14:58
ross-p-smith
ross-p-smith previously approved these changes May 13, 2024
Copy link
Collaborator

@ross-p-smith ross-p-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boom

adamdougal
adamdougal previously approved these changes May 13, 2024
Copy link
Collaborator

@adamdougal adamdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

A couple of little comments but we can address those later!

code/tests/functional/tests/functions/README.md Outdated Show resolved Hide resolved
gaurarpit
gaurarpit previously approved these changes May 13, 2024
@cecheta cecheta dismissed stale reviews from gaurarpit, ross-p-smith, and adamdougal via aab3071 May 13, 2024 08:46
Copy link
Collaborator

@adamdougal adamdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to get some coverage here!

@cecheta cecheta added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit 828ccd2 May 13, 2024
9 checks passed
@cecheta cecheta deleted the feat/748/functional-test branch May 13, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants