New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Removing index creation from init of AzureSearchHelper.py #872
Merged
komalg1
merged 36 commits into
Azure-Samples:main
from
komalg1:komal/bug-index-creation-init
May 13, 2024
Merged
fix: Removing index creation from init of AzureSearchHelper.py #872
komalg1
merged 36 commits into
Azure-Samples:main
from
komalg1:komal/bug-index-creation-init
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdougal
requested changes
May 10, 2024
komalg1
commented
May 10, 2024
code/tests/functional/backend_api/tests/default/test_conversation_custom.py
Outdated
Show resolved
Hide resolved
komalg1
commented
May 10, 2024
code/tests/functional/backend_api/tests/sk_orchestrator/test_response_without_tool_call.py
Outdated
Show resolved
Hide resolved
@komalg1 have you also tested this works when IV is disabled? |
adamdougal
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Yes tested 👍 |
superhindupur
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
How to Test