Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Adding params that we have ENV for #868

Merged
merged 2 commits into from May 13, 2024
Merged

Conversation

ross-p-smith
Copy link
Collaborator

@ross-p-smith ross-p-smith commented May 9, 2024

Purpose

Relates to #796

This is a part fix for #796 as we need to design this so that it works for people who use azd, plain bicep and the "Deploy to Azure" button. Not all environment variables have a corresponding input bicep param as they are outputs of the bicep. I'm also unsure how brittle we will make this if we allow people change the name of Azure resources through the environment variables, I think it was better if they were bicepparam's and the ENV values were the output. I will look into this next.

This PR just adds those values that are ENV and params so that you can deploy using azd up and then update using azd env set KEY VALUE and then azd up again and have the deployment respect the value you have just set.

This also has a small tweak to the B3 -> B1 issue

@ross-p-smith ross-p-smith requested a review from cecheta May 9, 2024 21:42
Copy link

github-actions bot commented May 9, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL227766770% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
173 0 💤 0 ❌ 0 🔥 11.924s ⏱️

Copy link
Collaborator

@adamdougal adamdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaurarpit
Copy link
Collaborator

Should we create a User Story/task for this ?

I'm also unsure how brittle we will make this if we allow people change the name of Azure resources through the environment variables, I think it was better if they were bicepparam's and the ENV values were the output. I will look into this next.

@ross-p-smith ross-p-smith added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit d917a30 May 13, 2024
11 checks passed
@ross-p-smith ross-p-smith deleted the ross/bicep-params branch May 13, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants