Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test support for Amd64 and Arm64 #101

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Add test support for Amd64 and Arm64 #101

merged 2 commits into from
Apr 17, 2023

Conversation

odidev
Copy link
Contributor

@odidev odidev commented Mar 24, 2023

This PR adds Amd64 and Arm64 job to dotnet.yml file.
Signed-off-by: odidev odidev@puresoftware.com

@odidev
Copy link
Contributor Author

odidev commented Apr 4, 2023

@DanielLarsenNZ, Could you please review this PR.

Copy link
Contributor

@DanielLarsenNZ DanielLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great thanks @odidev :) We don't have integration tests on this project - is it running OK on your machine?

<PackageReference Include="Microsoft.Azure.WebJobs.Extensions.Storage" Version="5.0.0" />
<PackageReference Include="Microsoft.NET.Sdk.Functions" Version="3.0.13" />
<PackageReference Include="Microsoft.Azure.WebJobs.Extensions.DurableTask" Version="2.6.1" />
<PackageReference Include="Microsoft.Azure.WebJobs.Extensions.Storage..Queues" Version="5.0.0" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storage..Queues is that a typo?

Signed-off-by: odidev <odidev@puresoftware.com>
@odidev
Copy link
Contributor Author

odidev commented Apr 10, 2023

@ DanielLarsenNZ, There are no integration tests on the github folder of Serverless-microservices-reference-architecture. In the github folder only .yml files are present in those files only build and test command are present.

Attaching the logs of yml files:

Dotnet.yml : dotnet.yml.txt
Nodejs.yml :nodejs.yml.txt
Spa .yml : spa.yml.txt

Storage..Queues is a typo error; I have amended the PR again by changing it to Storage.Queues

Could you please suggest how we can move forward with the integration test, or if the above yml tests are sufficient.

@DanielLarsenNZ DanielLarsenNZ merged commit 9324ae7 into Azure-Samples:main Apr 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants