Add MySQL App Service / ACA - fix typos and styles #48
Conversation
|
Commits after this comment are related to ACA setup as it's built on top of the mysql setup |
john0isaac
changed the title
john0isaac
changed the title
templates/conftest_flask_sql.py
Outdated
There was a problem hiding this comment.
If I remember this is due to a known issue - @john0isaac do you have the link to this?
There was a problem hiding this comment.
| {% endraw %} | ||
| architecture: x64 |
There was a problem hiding this comment.
Is this going to be a problem when testing against ARM?
There was a problem hiding this comment.
This change is not needed but I asked myself why are we disabling interpretation for architecture: x64
it's not related to jinja syntax so, it's safe to do it like that and the wrapping was not needed.
| @@ -81,6 +82,8 @@ To request support please create a [new discussion](https://github.com/kjaymille | |||
| - [Flask Azure Container Apps Postgres Addon Azure Container Apps](https://github.com/Azure-Samples/azure-flask-postgres-addon-aca) | |||
| - [Flask CosmosDB - MongoDB Adapter Azure Container Apps](https://github.com/Azure-Samples/azure-flask-cosmos-mongodb-aca) | |||
| - [Flask CosmosDB - MongoDB Adapter Azure App Service](https://github.com/Azure-Samples/azure-flask-cosmos-mongodb-appservice) | |||
| - [Flask MySQL - Flexible Server Azure App Service](https://github.com/john0isaac/azure-flask-mysql-flexible-appservice) | |||
There was a problem hiding this comment.
I think this is a temporary good choice to include working samples. In the long term. There should be samples that are created in the Azure-Samples Repo
error: django.db.utils.OperationalError: (2002, Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2))
Django has the same env vars for development and production. My production env vars started with Azure_something which made django deployment fail
fix mysql django password typo
Purpose
After building this I used Cookiecutter to generate the repo I previously created and there were no changes in the code.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?