Add last saved timestamp to status bar #402
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Add last saved to cloud timestamp to status bar.
What changed?
CloudSavetype indocument.service.tsto save last saved timestamp.BottomBar.tsxwhen user saves to cloud.BottomBar.tsxHow to test?
To test, make changes to the original document and click "Save to Cloud", an extra state displaying last saved timestamp will show on status bar right to "Save to Cloud".
Adding an extra prop in
CloudSavetype seems to involve some changes in database schema, as it throws an errorpublic.upsert_document(p_content, p_format, p_id, p_last_saved) in the schema cache.The screenshot is taken when ignoring this error.
Why make this change?
Last saved timestamp is a feature seen in other coding and productivity apps, it gives user an ease of mind. At critical times, e.g. if the user accidentally kills the session, they know where they were last time.