Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI option to block deleted rooms from being rejoined #166

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jkanefendt
Copy link

This PR adds a customized delete room dialog with an option to block the deleted room from being rejoined.

@jkanefendt jkanefendt changed the title Implemented ui option to block deleted rooms from being rejoined Add UI option to block deleted rooms from being rejoined Jul 7, 2021
@awesome-manuel
Copy link
Member

awesome-manuel commented Aug 18, 2021

Please fix the checks. Try yarn fix and run yarn test yourself.

@dklimpel
Copy link
Contributor

IMO during creation of this PR was the master broken. Perhaps it is only necessary to merge current master into this branch.

Comment on lines 474 to 475
export const DeleteRoomButton = props => {
const classes = useStyles(props);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please extract the DeleteRoomButton together with the DeleteRoomDialog into a separate file, so it can be reused by other views.

@dklimpel
Copy link
Contributor

Is there a plan for the 2nd DeleteButton.?

<BulkDeleteButton
{...props}
confirmTitle="resources.rooms.action.erase.title"
confirmContent="resources.rooms.action.erase.content"
undoable={false}
/>

At the moment have both buttons (list and detail view) the same function.

@jkanefendt
Copy link
Author

Is there a plan for the 2nd DeleteButton.?
At the moment have both buttons (list and detail view) the same function.

You mean the option shall be implemented for batch deletes as well? Yes, i agree. I'll try to fix this.

@awesome-manuel awesome-manuel added the enhancement New feature or request label Feb 7, 2024
Copy link
Member

@awesome-manuel awesome-manuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase onto latest master

@@ -68,7 +68,7 @@ const resourceMap = {
},
delete: params => ({
endpoint: `/_synapse/admin/v1/rooms/${params.id}`,
body: { block: false },
body: { block: !!params.block },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to use params.meta.block in react-admin 4

@awesome-manuel awesome-manuel added the help wanted Extra attention is needed label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants