Assert the correct package manager is used for run commands #40893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scinos
commented
Apr 8, 2020
| "sync:blog-posts-block": "./bin/sync-blog-posts-block.sh", | ||
| "wpcom-sync": "./bin/wpcom-watch-and-sync.sh", | ||
| "prepare": "npm run sync:blog-posts-block --nodemodules" | ||
| "full-site-editing": "check-npm-client && calypso-build --source='dotcom-fse'", |
There was a problem hiding this comment.
All these changes would be so much cleaner if package.json had support for prerun... oh well 🤷♂
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
scinos
force-pushed
the
update/assert-package-manager
branch
from
34b6664
to
97dee66
Compare
scinos
added
the
[Status] Needs Review
scinos
force-pushed
the
update/assert-package-manager
branch
from
d14c2b2
to
06540cc
Compare
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This is part of yarn migration (see #40882). Once we have migrated in yarn and we are confident that everybody is used to the change, we can remove these guards.
Testing instructions
npm run...commands. Everything should work fine.yarn run.... You should see the error "please use npm instead of yarn"