Trying out yarn #39121

blowery · 2020-01-29T00:46:16Z

Try out yarn!

matticbot · 2020-01-29T00:46:19Z

Test live: https://calypso.live/?branch=try/yarn-package-manager

jameslnewell · 2020-01-29T04:50:59Z

While running npm start I was getting errors with wpcom trying to use the symlinked package in package/wpcom.js/src/index.js. It looks like this package is basically a historical copy as there's no file: references and no prepare script to build the files.

The make command in its package.json didn't produce workable output so I've moved the whole package from packages/wpcom.js/ to legacy/wpcom.js so yarn will install the published version and avoid symlinking the local version.

matticbot · 2020-01-29T04:53:04Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~18 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-gutenboarding         +256 B  (+0.0%)      -58 B  (-0.0%)
entry-main                   +90 B  (+0.0%)      +22 B  (+0.0%)
entry-login                  +90 B  (+0.0%)      +25 B  (+0.0%)
entry-domains-landing        +56 B  (+0.0%)       -7 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~4819 bytes removed 📉 [gzipped])

name              parsed_size           gzip_size
checkout             -22328 B  (-1.7%)    -4332 B  (-1.3%)
devdocs               +1863 B  (+1.2%)       +3 B  (+0.0%)
stats                   -37 B  (-0.0%)      -37 B  (-0.0%)
settings-writing        -37 B  (-0.0%)      -22 B  (-0.0%)
post-editor             -37 B  (-0.0%)       +8 B  (+0.0%)
help                    -37 B  (-0.0%)      -25 B  (-0.0%)
concierge               -37 B  (-0.0%)     -147 B  (-0.2%)
backups                 -37 B  (-0.0%)     -140 B  (-0.2%)
activity                -37 B  (-0.0%)      -58 B  (-0.1%)
comments                -36 B  (-0.0%)      -45 B  (-0.0%)
woocommerce             +22 B  (+0.0%)      -12 B  (-0.0%)
purchases               +22 B  (+0.0%)      -12 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~83040 bytes added 📈 [gzipped])

name                                   parsed_size           gzip_size
async-load-design-playground              +98266 B  (+5.8%)   +27747 B  (+7.1%)
async-load-design                         +98266 B  (+5.6%)   +27747 B  (+6.8%)
async-load-design-blocks                  +98250 B  (+3.5%)   +27707 B  (+4.2%)
async-load-lib-happychat-connection         +270 B  (+0.4%)       +9 B  (+0.1%)
async-load-signup-steps-clone-point          -37 B  (-0.0%)      -23 B  (-0.1%)
async-load-blocks-inline-help-popover        -37 B  (-0.0%)     -116 B  (-0.2%)
async-load-blocks-calendar-popover           -36 B  (-0.0%)      -31 B  (-0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

jameslnewell · 2020-01-29T04:57:11Z

client/package.json

@@ -119,7 +119,7 @@
 		"path-browserify": "1.0.0",
 		"percentage-regex": "3.0.0",
 		"phone": "2.4.2",
-		"photon": "file:../packages/photon",
+		"photon": "^3.0.0",


We probably want to use ^ syntax everywhere there was a file: reference - otherwise everytime a local package is bumped we'll have to go and update all the references to it so yarn continues to symlink the workspace instead of installing the specific version from the registry.

🤔 what happens if local version is bumped v4 in this case? Would we then want to use * instead?

Yeah for private packages like client/* it might be a good idea to encourage the developer who makes a change to also update any usages across the codebase.

In packages published to the registry, * would have unintended affects.

This is a very tricky subject. If we don't force version sync across all the monrepo (ie. update all usages of a package when it changes version), we may end up in this scenario:

./packages/packageA depends on packageB@1.0.0

./packages/packageB is bumped to 2.0.0, with breaking changes

Dependency in ./packages/packageA is not updated.

That will make ./packages/packageA code incompatible with ./packages/packageB, which will be a source of confusion and a pain to debug.

Also, consumers of packageA and packageB may end up with two copies: packageB@1.0.0 (because trans dep from packageA) and packageB@2.0.0 (because they are on the latest version).

One of the downsides is that updating a package will have a "cascade" effect that may end up updating a ton of packages, therefore requiring a lot of releases. And by extension, adding extra work for consumers of our packages if they want to be up to date.

I'm all for adding a version constraint that enforces workspaces are always symlinked (the goal of adding ^ was to keep it symlinked for longer). I tried yarn@2 with its constraints in mind but the ecosystem isn't stable enough yet. Maybe we can use manypkg to enforce that for now?

blowery · 2020-01-29T15:01:14Z

@jsnajdr and @sgomes are working on getting wpcom.js into packages properly in some other PRs. There's also #39139 coming in that will likely follow the path same kind of path.

package.json

jameslnewell · 2020-01-30T00:23:58Z

The remaining CI failure:

  Module <rootDir>/node_modules/@wordpress/jest-preset-default/scripts/setup-globals.js in the setupFiles option was not found.
         <rootDir> is: /home/circleci/wp-calypso/apps/full-site-editing

Is due to @wordpress/jest-preset-default containing fixed paths instead of relying on the traditional NodeJS resolution algorithm e.g. https://github.com/WordPress/gutenberg/blob/master/packages/jest-preset-default/jest-preset.js#L8

Converting the paths to use require.resolve gets things working. I'll work on a PR.

Edit: WordPress/gutenberg#19957

blowery · 2020-01-30T12:48:15Z

yarn-deduplicate seems like a good idea. We could enforce it via a post-install script perhaps? Not sure how that will tie in with Renovate though...

blowery · 2020-02-11T14:50:24Z

fse just moved to dotcom-fse

blowery · 2020-02-11T15:10:59Z

rebased this and force-pushed it @jameslnewell

.circleci/config.yml

blowery · 2020-02-11T16:50:05Z

Tests passed!

lerna.json

.circleci/config.yml

Inital moves to yarn workspaces - add workspaces to root package.json - move to actual semver versions for monorepo packages instead of file: refs replaced file: with local package version, updated npm run and circleci update docker ignore engines fix install moved wpcom.js remove npm lock file, fix deps file, update wpcom dep use ^ wherever there was a file: reference update @automattic/color-studio to version that doesn't spec engines resolve a single instance of @emotion/core remove --ignore-engines update lerna config to teach it about yarn and workspaces add e2e tests to workspaces cleanup after rebase updated @wordpress/jest-preset-default resolve delete conflicts Inital moves to yarn workspaces - add workspaces to root package.json - move to actual semver versions for monorepo packages instead of file: refs replaced file: with local package version, updated npm run and circleci ignore engines moved wpcom.js remove npm lock file, fix deps file, update wpcom dep update @automattic/color-studio to version that doesn't spec engines resolve a single instance of @emotion/core remove --ignore-engines add e2e tests to workspaces cleanup after rebase updated @wordpress/jest-preset-default updated lock use immutable instead of frozen-lockfile remove package-lock.json from lerna ignores remove unnecessary -- when running typecheck spec the yarn version we want tell renovate to run yarn-deduplicate --fewer after each update run loosen yarn version to match up with what circle ci has npm->yarn for various steps and tasks move back to --frozen-lockfile, --immutable is a 2.0 thing Update docs/lockfile.md Co-Authored-By: Marin Atanasov <8436925+tyxla@users.noreply.github.com> Update docs/monorepo.md Co-Authored-By: Marin Atanasov <8436925+tyxla@users.noreply.github.com> update lockfile docs update install script fix grammar in lockfile docs remove redundant -- update npm text and commands in various locations fix missed conflicts bring back package-lock.json for e2e tests cleanup after rebase update new references to npm to use yarn fix file: reference fix lock file and usage of npm resolve conflict fix typings issues after rebase due to multiple versions of a package

…eing hosted

…to be on the root

scinos · 2020-04-17T07:12:01Z

Merged as part of #41140

jameslnewell reviewed Jan 29, 2020

View reviewed changes

jameslnewell reviewed Jan 30, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

blowery assigned blowery and jameslnewell Jan 30, 2020

blowery added [Status] In Progress Framework labels Jan 30, 2020

jameslnewell force-pushed the try/yarn-package-manager branch from 443b52a to 66d84cf Compare February 9, 2020 21:46

blowery marked this pull request as ready for review February 11, 2020 13:10

blowery requested review from a team as code owners February 11, 2020 13:10

blowery force-pushed the try/yarn-package-manager branch from 48dc7be to 7522e25 Compare February 11, 2020 15:10

simison reviewed Feb 11, 2020

View reviewed changes

.circleci/config.yml Show resolved Hide resolved

blowery added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Feb 11, 2020

blowery force-pushed the try/yarn-package-manager branch from e90f00e to 5a9aebb Compare February 11, 2020 16:51

simison reviewed Feb 11, 2020

View reviewed changes

lerna.json Outdated Show resolved Hide resolved

simison reviewed Feb 11, 2020

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

blowery force-pushed the try/yarn-package-manager branch from ac0401e to a6071b9 Compare February 11, 2020 21:23

jameslnewell reviewed Feb 11, 2020

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

blowery and others added 21 commits April 7, 2020 09:06

Link missing packages in the monorepo

759a3d4

Clean up package.json files

d680925

Delete debug file

e98cbd3

Adds vfile-message 2 as a root dependency to stop vfile-message 1.x b…

a5c884a

…eing hosted

Fix typos in npm scripts

e4e556b

Fix typo in circleci config

aeefbab

Bump @automattic/calypso-analytics to 1.0.0-alpha.1

7d0324f

Update @automattic/full-site-editing to 0.23.0

3bb3ff8

Update yarn.lock

7535e80

Adds missing 'cookie' dependency in '@automattic/calypso-analytics'

4eec730

Migrate ICFY action to use yarn

8441200

Use a valid node version

6ca1378

Clean up merge errors

77149a8

Force hoisting of vfile-message^2.0.0 to prevent vfile-message@1.1.1 …

6438052

…to be on the root

Update yarn.lock

0a62374

Update yarn.lock

925a4d1

Uses yarn's set-polivy to fix the veresion to 1.22.4

b2d652b

Move devDependencies to dependencies

c4cda6b

Add documentationa about yarn

6f40d6c

Use the correct binary for package.json linting

673880f

scinos force-pushed the try/yarn-package-manager branch from ce82ff1 to 673880f Compare April 7, 2020 07:09

scinos added 3 commits April 7, 2020 16:01

Update yarn.lock

23620bb

Check that npm scripts are run via yarn

36adcf8

Trigger CI

1f63eaa

scinos mentioned this pull request Apr 8, 2020

Migrate to yarn #40882

Closed

11 tasks

scinos closed this Apr 17, 2020

matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 17, 2020

scinos deleted the try/yarn-package-manager branch September 11, 2020 07:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trying out yarn #39121

Trying out yarn #39121

blowery commented Jan 29, 2020 •

edited by scinos

matticbot commented Jan 29, 2020

jameslnewell commented Jan 29, 2020 •

edited

matticbot commented Jan 29, 2020 •

edited

jameslnewell Jan 29, 2020 •

edited

simison Feb 11, 2020

jameslnewell Feb 12, 2020

scinos Mar 2, 2020

jameslnewell Mar 3, 2020 •

edited

blowery commented Jan 29, 2020

jameslnewell commented Jan 30, 2020 •

edited

blowery commented Jan 30, 2020

blowery commented Feb 11, 2020

blowery commented Feb 11, 2020

blowery commented Feb 11, 2020

scinos commented Apr 17, 2020

Trying out yarn #39121

Trying out yarn #39121

Conversation

blowery commented Jan 29, 2020 • edited by scinos

matticbot commented Jan 29, 2020

jameslnewell commented Jan 29, 2020 • edited

matticbot commented Jan 29, 2020 • edited

jameslnewell Jan 29, 2020 • edited

Choose a reason for hiding this comment

simison Feb 11, 2020

Choose a reason for hiding this comment

jameslnewell Feb 12, 2020

Choose a reason for hiding this comment

scinos Mar 2, 2020

Choose a reason for hiding this comment

jameslnewell Mar 3, 2020 • edited

Choose a reason for hiding this comment

blowery commented Jan 29, 2020

jameslnewell commented Jan 30, 2020 • edited

blowery commented Jan 30, 2020

blowery commented Feb 11, 2020

blowery commented Feb 11, 2020

blowery commented Feb 11, 2020

scinos commented Apr 17, 2020

blowery commented Jan 29, 2020 •

edited by scinos

jameslnewell commented Jan 29, 2020 •

edited

matticbot commented Jan 29, 2020 •

edited

jameslnewell Jan 29, 2020 •

edited

jameslnewell Mar 3, 2020 •

edited

jameslnewell commented Jan 30, 2020 •

edited