Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic answer feedback #6497

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

Bones5
Copy link

@Bones5 Bones5 commented Feb 8, 2023

Fixes #5370 (partially)

Changes proposed in this Pull Request

*Add a feedback option for multi and single line questions.

Testing instructions

*Add a multi or single line question and enter feedback.
*Feed back should display on relevant field on front end

Screenshot / Video

image

@Bones5
Copy link
Author

Bones5 commented Feb 8, 2023

This is currently for the admin blocks, I can add the front end if the implementation makes sense.

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #6497 (25d6b60) into trunk (13351dc) will decrease coverage by 0.26%.
The diff coverage is n/a.

❗ Current head 25d6b60 differs from pull request most recent head 32d5407. Consider uploading reports for the commit 32d5407 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk    #6497      +/-   ##
============================================
- Coverage     47.11%   46.85%   -0.26%     
+ Complexity     9817     9745      -72     
============================================
  Files           473      465       -8     
  Lines         34731    34417     -314     
  Branches        277      276       -1     
============================================
- Hits          16362    16125     -237     
+ Misses        18163    18086      -77     
  Partials        206      206              
Impacted Files Coverage Δ
includes/class-sensei-autoloader.php 14.58% <0.00%> (-6.25%) ⬇️
includes/internal/emails/class-email-post-type.php 87.50% <0.00%> (-4.17%) ⬇️
includes/class-sensei-updates.php 76.08% <0.00%> (-0.68%) ⬇️
...ncludes/course-theme/class-sensei-course-theme.php 18.32% <0.00%> (-0.10%) ⬇️
includes/internal/emails/class-email-blocks.php
includes/internal/emails/class-settings-menu.php
includes/internal/emails/class-email-generator.php
assets/blocks/email-editor.js
...ncludes/internal/emails/class-email-list-table.php
includes/internal/emails/class-email-sender.php
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 263433d...32d5407. Read the comment docs.

@TamsinGabriel
Copy link

Tested - doesn't consistently provide option to give generic question feedback

@Bones5
Copy link
Author

Bones5 commented Mar 14, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Feedback Options to Open-ended Question Types
2 participants