Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace my courses login form with standard Wordpress login form #3875

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Jan 6, 2021

Fixes #3312

Changes proposed in this Pull Request

  • Use wp_login_form to render login form in My Courses page

TODO

Testing instructions

  • Visit the My Courses page and use the login form

Removed Hooks

These hooks are removed in favor of their core counterparts:

  • sensei_login_form_inside_before -> login_form_top
  • sensei_login_form_inside_after_password_field -> login_form_middle
  • sensei_login_form_inside_after -> login_form_bottom

We could also just deprecate them, and set it up so they are still called from these core hooks, but that might do more harm if the user added callbacks to both the sensei login and core login hooks.

Screenshot / Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use WordPress standard login form on My Courses page
1 participant