Saving a model fails with mongo error: MongoError: Unknown modifier: $pushAll #5574

dyladan · 2017-08-23T13:54:15Z

Do you want to request a feature or report a bug?

Report a bug

What is the current behavior?

Test passing on local machine but failing on jenkins server with the exact same versions. The only difference is local is macos and jenkins is ubuntu as far as I can tell.

On MacOS Sierra, node 8.4 and 7.11, mongodb 3.4.7, and mongoose 4.11.7 the following test passes, but on our jenkins server with the exact same versions on an ubuntu 16.04 server fails.

  it("should successfully allow an alias that matches a service", async () => {
    const aliasTag = "this is a test";
    const appAlias = await AliasController.create(user, appAliasSpec);
    const serviceAlias = await AliasController.create(user, serviceAliasSpec);

    appAlias.aliases.push(aliasTag);
    await appAlias.save(); // This is the line that fails in jenkins

    serviceAlias.aliases.push(aliasTag);
    await serviceAlias.save();

    const confAppAlias = await AliasController.getById(appAlias._id);
    const confServiceAlias = await AliasController.getById(serviceAlias._id);
    expect(confAppAlias.aliases[1]).to.equal(aliasTag);
    expect(confServiceAlias.aliases[1]).to.equal(aliasTag);
  });

Here is the exact error that i'm getting:

{
	"message": "Unknown modifier: $pushAll",
	"name": "MongoError",
	"stack": "MongoError: Unknown modifier: $pushAll\n    at Function.MongoError.create (/var/lib/jenkins/workspace/davis-cloudcontrol/node_modules/mongodb-core/lib/error.js:31:11)\n    at toError (/var/lib/jenkins/workspace/davis-cloudcontrol/node_modules/mongodb/lib/utils.js:139:22)\n    at /var/lib/jenkins/workspace/davis-cloudcontrol/node_modules/mongodb/lib/collection.js:1060:67\n    at /var/lib/jenkins/workspace/davis-cloudcontrol/node_modules/mongodb-core/lib/connection/pool.js:469:18\n    at _combinedTickCallback (internal/process/next_tick.js:131:7)\n    at process._tickCallback (internal/process/next_tick.js:180:9)",
	"code": 9
}

edit: Here is a more readable version of the stack trace

MongoError: Unknown modifier: $pushAll
    at Function.MongoError.create (/var/lib/jenkins/workspace/davis-cloudcontrol/node_modules/mongodb-core/lib/error.js:31:11)
    at toError (/var/lib/jenkins/workspace/davis-cloudcontrol/node_modules/mongodb/lib/utils.js:139:22)
    at /var/lib/jenkins/workspace/davis-cloudcontrol/node_modules/mongodb/lib/collection.js:1060:67
    at /var/lib/jenkins/workspace/davis-cloudcontrol/node_modules/mongodb-core/lib/connection/pool.js:469:18
    at _combinedTickCallback (internal/process/next_tick.js:131:7)
    at process._tickCallback (internal/process/next_tick.js:180:9)

The text was updated successfully, but these errors were encountered:

sobafuchs · 2017-08-23T14:35:19Z

can you do mongoose.set('debug', true) and paste the mongo output?

dyladan · 2017-08-23T15:01:17Z

edit: more clear output

Mongoose: aliases.update({ _id: ObjectId("599d98122b72d12e0ba858b4") }, { '$pushAll': { aliases: [ 'this is a test' ] }, '$set': { updatedAt: new Date("Wed, 23 Aug 2017 14:58:26 GMT") }, '$inc': { __v: 1 } })
{"name":"davis","hostname":"ld-ub-bm980a98v","pid":11787,"level":50,"err":{"message":"Unknown modifier: $pushAll","name":"MongoError","stack":"MongoError: Unknown modifier: $pushAll
    at Function.MongoError.create (/var/lib/jenkins/workspace/davis-cloudcontrol/node_modules/mongodb-core/lib/error.js:31:11)
    at toError (/var/lib/jenkins/workspace/davis-cloudcontrol/node_modules/mongodb/lib/utils.js:139:22)
    at /var/lib/jenkins/workspace/davis-cloudcontrol/node_modules/mongodb/lib/collection.js:1060:67
    at /var/lib/jenkins/workspace/davis-cloudcontrol/node_modules/mongodb-core/lib/connection/pool.js:469:18
    at _combinedTickCallback (internal/process/next_tick.js:131:7)
    at process._tickCallback (internal/process/next_tick.js:180:9)","code":9},"msg":"An unhandled Mongo error occurred.","time":"2017-08-23T14:58:26.201Z","v":0}

dyladan · 2017-08-23T16:17:39Z

For what it's worth, I checked the debug output in our local development and production environments and they're both using the $pushAll modifier successfully. Mongo is installed from the official packages in all cases. Development machines are windows and MacOS, production machines are amazon linux.

vkarpov15 · 2017-08-29T00:30:42Z

Can you connect to your jenkins mongodb instance using the mongo shell and double check the version using db.version?

$ mongo test
MongoDB shell version v3.4.1
connecting to: mongodb://127.0.0.1:27017/test
MongoDB server version: 3.4.1 
> db.version()
3.4.1
> ^C
bye

You can also print the server version out using the serverStatus() command using mongoose:

const mongoose = require('mongoose');

mongoose.connect('mongodb://localhost:27017/test');

mongoose.connection.on('open', function() {
  mongoose.connection.db.admin().serverStatus(function(error, info) {
    console.log(info.version);
  });
});

Please double check your version first, official packages tend to fall out of date pretty quickly.

Spown · 2017-09-21T04:07:15Z

yep, have the same error. tried to move from 3.2 to 3.5 (no data migration). I have an array field

    'liked': {
        'item':[ {
            'id': {'type': Types.ObjectId, 'ref': 'Item'},
            'score': {'type': Number, 'max': 100, 'default': -1},
            'comment': {'type': String, 'maxlength': 65000, 'trim': true, 'default': '', 'set': san.methods.safe}
        } ]
    },

I know, id is not the best field name, but hey, it worked in 3.2. In 3.5 it fails after trying to .save() the doc after an Item been pushed into the array. I push the items via .push() and then mark the field .markModified('liked.item');. schould be simple.

vkarpov15 · 2017-09-26T00:53:38Z

MongoDB 3.5?

Spown · 2017-09-26T09:30:24Z

yes

 targetMinOS: Windows 7/Windows Server 2008 R2
 db version v3.5.13
 git version: 52bbaa007cd84631d6da811d9a05b59f2dfad4f3
 OpenSSL version: OpenSSL 1.0.1u-fips  22 Sep 2016
 allocator: tcmalloc
 modules: none
 build environment:
     distmod: 2008plus-ssl
     distarch: x86_64
     target_arch: x86_64

vkarpov15 · 2017-09-26T18:24:30Z

Well that's one problem, mongodb 3.5 is an unstable dev release and should not be used. $pushAll has been deprecated for a long time so perhaps they got rid of it in 3.5. @mbroadst can you clarify?

We added a usePushEach option to work around this a while back: #4455 , that should be a workaround for this issue:

new Schema({ arr: [String] }, { usePushEach: true });

mbroadst · 2017-09-26T20:04:52Z

@vkarpov15 yes it's been removed for featureCompatibilityVersion=3.6

vkarpov15 · 2017-10-02T03:10:55Z

Touche. In which case we'll make sure to get #5670 out.

rankitbishnoi · 2017-12-20T08:24:42Z

i am having the same exact problem i am using mongodb v3.6 on my ubuntu. if the pushAll is removed from db than how should i save the instance.. please provide me any alternative

dyladan · 2017-12-20T14:19:42Z

@rankitbishnoi You can get around this temporarily by adding the usePushEach option on each schema definition in the options.

chaddjohnson · 2017-12-20T18:18:59Z

@vkarpov15 Thanks for the fantastic library sir.

I, too, anm experiencing this issue with Mongoose 4.13.7 and MongoDB 3.6.0.

UPDATE: Adding usePushEach: true to schema options for models resolved this.

rod-stuchi · 2017-12-21T12:35:06Z

@dyladan @chaddjohnson really works.
thanks a lot!

raphaelbp12 · 2017-12-25T09:49:29Z

please, how can I do this? how can I add this to schema options? thank you!

chaddjohnson · 2017-12-25T17:51:14Z

@raphaelbp12 Here are the docs on using schema options: http://mongoosejs.com/docs/guide.html

danieltanfh95 · 2017-12-31T06:18:03Z

Updating the schema does not change this behavior. It's not working for older data in the database already for 3.6.

Edit: Reverting back to version 3.4 solved the problem.

frederico-alves · 2017-12-31T12:50:40Z

I was having a similar issue running the code in my machine. I think is because of Mongoose 5 and MongoDB 3.6. Try to revert back:

Mongoose to version 4.13.8 (npm install mongoose@4.13.8 --save), and
MongoDB to 3.4 (you can check the version typing db.version() ).

It worked for me! :)

vkarpov15 · 2017-12-31T15:24:34Z

Mongoose 5 should not be affected by this issue, it doesn't use $pushAll anywhere. If you get this error with mongoose 5, please open up an issue with code samples 👍

In order for devs to be able to work around the issues described in Automattic/mongoose#5574 we need to be able to supply the `usePushEach` flag to the Mongoose SchemaOptions. This options functionality is described in Automattic/mongoose#4455 and is required for anyone who modifies arrays inline who is using Mongoose 4 and MongoDB 3.6+ Testing: Copied changes to local project and verified compilation worked.

JoseRFJuniorLLMs · 2018-01-25T01:33:33Z

PS C:\Users\paula\projetos\apiNode\src> node index.js
{ MongoError: Unknown modifier: $pushAll
at Function.MongoError.create (C:\Users\paula\projetos\apiNode\node_modules\mongodb-core\lib\error.js:31:11)
at toError (C:\Users\paula\projetos\apiNode\node_modules\mongodb\lib\utils.js:139:22)
at C:\Users\paula\projetos\apiNode\node_modules\mongodb\lib\collection.js:1059:67
at C:\Users\paula\projetos\apiNode\node_modules\mongodb-core\lib\connection\pool.js:469:18
at _combinedTickCallback (internal/process/next_tick.js:131:7)
at process._tickCallback (internal/process/next_tick.js:180:9)
name: 'MongoError',
message: 'Unknown modifier: $pushAll',
driver: true,
index: 0,
code: 9

rivers-lis · 2018-01-30T16:28:51Z

Всем привет, подскажите пожалуйста как исправить ошибку Неизвестный модификатор: $ pushAll

rivers-lis · 2018-01-30T16:29:15Z

Пробовал вот так не работает
const mongoose = require ('mongoose')
const Схема = mongoose.Schema

const UserSchema = new Schema ({
telegramId: {
type: Number,
required: true,
usePushEach: true
},

films: {
type: [String],
default: []
}
})

mongoose.model ('users', UserSchema)

chaddjohnson · 2018-01-30T16:52:03Z

@rivers-lis You have to add usePushEach to the schema options, not to the schema, like so:

new Schema({ ... }, { usePushEach: true });

rivers-lis · 2018-01-30T17:03:29Z

Как то вот так
const mongoose = require('mongoose')
const Schema = mongoose.Schema

const UserSchema = new Schema({
telegramId: {
type: Number,
required: true
},

films: {
    type: [String],
    default: []
}

})

new Schema({}, {usePushEach: true})

mongoose.model('users', UserSchema)

ankit-chheda · 2018-03-02T16:40:49Z

new Schema({ ... }, { usePushEach: true });
This solves the error for me too on version 4.4.12 and 5.0.7

Was getting this error while adding the lyrics. Issue and patch mentioned here Automattic/mongoose#5574 (comment) ```bundle.js:6882 Uncaught (in promise) Error: GraphQL error: Unknown modifier: $pushAll at new ApolloError (bundle.js:6885) at bundle.js:15869```

DanGDroid · 2019-01-28T12:49:15Z

Как то вот так
const mongoose = require('mongoose')
const Schema = mongoose.Schema

const UserSchema = new Schema({
telegramId: {
type: Number,
required: true
},
films: {
    type: [String],
    default: []
}
})

new Schema({}, {usePushEach: true})

mongoose.model('users', UserSchema)

sorry cannot read Russian

vkarpov15 · 2019-01-31T16:49:42Z

@DanGDroid roughly translated "Как то вот так" -> "Something like this"

Automattic/mongoose#5574

sobafuchs added the needs clarification This issue doesn't have enough information to be actionable. Close after 14 days of inactivity label Aug 23, 2017

vkarpov15 closed this as completed Sep 26, 2017

vkarpov15 mentioned this issue Sep 26, 2017

Turn on usePushEach by default #5670

Closed

alangibson mentioned this issue Oct 12, 2017

MongoError: Unknown modifier: $pushAll when linking Twitter account sahat/hackathon-starter#745

Closed

stieg mentioned this issue Jan 19, 2018

Add usePushEach flag to Mongoose Schema Options DefinitelyTyped/DefinitelyTyped#23042

Merged

15 tasks

CalgaryMichael mentioned this issue Jan 29, 2018

Throw Exception Unknown modifier: $pushAll when run update(push_all) MongoEngine/mongoengine#1729

Closed

shingi mentioned this issue Feb 17, 2018

Saving a model fails with mongo error: MongoError: Unknown modifier: adredge/node-acceptance-testing#1

Open

losingle mentioned this issue Apr 29, 2018

MongoDB version 3.6.3 $pushAll Error sdelements/lets-chat#778

Open

hsiaosiyuan0 mentioned this issue May 11, 2018

bump mongoose version to 5.0 eggjs/egg-mongoose#20

Merged

4 tasks

EtienneBoutet mentioned this issue Jun 18, 2018

Add usePushEach flag to Mongoose Schema Options DefinitelyTyped/DefinitelyTyped#26639

Merged

16 tasks

vcorreze mentioned this issue Jul 30, 2018

Error 500 on settings due to old mongodb feature used cross-solution/YAWIK#472

Closed

metju90 mentioned this issue Aug 4, 2018

"Unknown modifier: $pushAll" StephenGrider/Lyrical-GraphQL#17

Open

jkonstan mentioned this issue Aug 27, 2018

Unknown modifier: $pushAll" gothinkster/node-express-realworld-example-app#57

Open

jrichardsz added a commit to jrichardsz/attendance-system that referenced this issue Nov 10, 2018

Fix Automattic/mongoose#5574 , add nodemon and improve readme

5549440

jrichardsz mentioned this issue Nov 10, 2018

Fix MongoError: Unknown modifier: $pushAll , add nodemon and improve readme lexyblazy/attendance-system#1

Merged

Finkes added a commit to coach-plus/server that referenced this issue Mar 29, 2019

fix user registration

7c94197

Automattic/mongoose#5574

ikas mentioned this issue Nov 19, 2019

Tests for vocabulary-dataset relationship CRUD operations resource-watch/vocabulary-tag#4

Merged

tarassov mentioned this issue Apr 14, 2022

fix: исправить ошибку с записью комментов projectKitchenBali/react-project-kitchen-backend#1

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Saving a model fails with mongo error: MongoError: Unknown modifier: $pushAll #5574

Saving a model fails with mongo error: MongoError: Unknown modifier: $pushAll #5574

dyladan commented Aug 23, 2017 •

edited

sobafuchs commented Aug 23, 2017

dyladan commented Aug 23, 2017 •

edited

dyladan commented Aug 23, 2017

vkarpov15 commented Aug 29, 2017

Spown commented Sep 21, 2017

vkarpov15 commented Sep 26, 2017

Spown commented Sep 26, 2017

vkarpov15 commented Sep 26, 2017

mbroadst commented Sep 26, 2017

vkarpov15 commented Oct 2, 2017

rankitbishnoi commented Dec 20, 2017

dyladan commented Dec 20, 2017

chaddjohnson commented Dec 20, 2017 •

edited

rod-stuchi commented Dec 21, 2017

raphaelbp12 commented Dec 25, 2017

chaddjohnson commented Dec 25, 2017

danieltanfh95 commented Dec 31, 2017 •

edited

frederico-alves commented Dec 31, 2017 •

edited

vkarpov15 commented Dec 31, 2017

JoseRFJuniorLLMs commented Jan 25, 2018

rivers-lis commented Jan 30, 2018

rivers-lis commented Jan 30, 2018

chaddjohnson commented Jan 30, 2018

rivers-lis commented Jan 30, 2018

ankit-chheda commented Mar 2, 2018

DanGDroid commented Jan 28, 2019

vkarpov15 commented Jan 31, 2019

Saving a model fails with mongo error: MongoError: Unknown modifier: $pushAll #5574

Saving a model fails with mongo error: MongoError: Unknown modifier: $pushAll #5574

Comments

dyladan commented Aug 23, 2017 • edited

sobafuchs commented Aug 23, 2017

dyladan commented Aug 23, 2017 • edited

dyladan commented Aug 23, 2017

vkarpov15 commented Aug 29, 2017

Spown commented Sep 21, 2017

vkarpov15 commented Sep 26, 2017

Spown commented Sep 26, 2017

vkarpov15 commented Sep 26, 2017

mbroadst commented Sep 26, 2017

vkarpov15 commented Oct 2, 2017

rankitbishnoi commented Dec 20, 2017

dyladan commented Dec 20, 2017

chaddjohnson commented Dec 20, 2017 • edited

rod-stuchi commented Dec 21, 2017

raphaelbp12 commented Dec 25, 2017

chaddjohnson commented Dec 25, 2017

danieltanfh95 commented Dec 31, 2017 • edited

frederico-alves commented Dec 31, 2017 • edited

vkarpov15 commented Dec 31, 2017

JoseRFJuniorLLMs commented Jan 25, 2018

rivers-lis commented Jan 30, 2018

rivers-lis commented Jan 30, 2018

chaddjohnson commented Jan 30, 2018

rivers-lis commented Jan 30, 2018

ankit-chheda commented Mar 2, 2018

DanGDroid commented Jan 28, 2019

vkarpov15 commented Jan 31, 2019

dyladan commented Aug 23, 2017 •

edited

dyladan commented Aug 23, 2017 •

edited

chaddjohnson commented Dec 20, 2017 •

edited

danieltanfh95 commented Dec 31, 2017 •

edited

frederico-alves commented Dec 31, 2017 •

edited