Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for the unbound variable error seen on run_swiftlint version 3.4.0 #92

Merged
merged 3 commits into from
May 15, 2024
Merged

Fix for the unbound variable error seen on run_swiftlint version 3.4.0 #92

merged 3 commits into from
May 15, 2024

Conversation

iangmaia
Copy link
Contributor

This is a fix for the error

run_swiftlint: line 17: $1: unbound variable

This error was seen when running run_swiftlint from Ruby's system() call on CI.

  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@iangmaia iangmaia requested a review from AliSoftware May 15, 2024 11:40
@iangmaia iangmaia self-assigned this May 15, 2024
@iangmaia iangmaia marked this pull request as ready for review May 15, 2024 11:43
AliSoftware
AliSoftware requested changes May 15, 2024
View reviewed changes
bin/run_swiftlint Outdated Show resolved Hide resolved
@iangmaia @AliSoftware
Check for the number of arguments
0b8f79a 
Co-authored-by: Olivier Halligon <olivier.halligon@automattic.com>
@iangmaia iangmaia merged commit 2a67b74 into trunk May 15, 2024
4 checks passed
@iangmaia iangmaia deleted the iangmaia/fix-run-swiftlint branch May 15, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliSoftware AliSoftware AliSoftware approved these changes

Assignees

@iangmaia iangmaia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iangmaia @AliSoftware