Ui settings fixes #235
Open
Ui settings fixes #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now "Coordinate Base" settings get loaded when user change away from default "Shared Coordinates".
…e checkmark state. Databinding is added to "Update project information", "Assign adress to building" and "Assign address to site" instad of check/uncheck events. Fixed missing save settings on "Project Address" dialog
|
@AngelVelezSosa is this going to be part of the next version 2020 and 2021? |
|
@WawanSolihin - is this going to be part of the next version 2020 and 2021? |
|
@AngelVelezSosa and @WawanSolihin Can you say anything about the plans to include our code in this pullrequest? |
|
I will take a look. I think the coordinate base is already remembered in the latest IfcExporter. Left the "Assign address to .." that is still not remembered. |
Thanks, I found that the Coordinate Base is saved and loaded, so thats fixed :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 dialogs where settings are not saved/read for further use.
If you create a custom setting like "Setup 1" and change the "Coordinate Base" setting it don't remember the setting after export and close.
When you open the export dialog again the setting is set back to "Coordinate Base" = "Shared Coordinates".
This pull request fixes this issue and it saves/reads the changes user made.
I have marked the setting on the dialog on next picture.
The 2 marked settings on the next picture have same issue, they don't save changes user have made. The name of the settings are "Assign address to building" and "Assign address to site".
The setting "Assign address to building" always have checkmark set in the dialog and don't remember if user uncheck it.
The setting "Assign address to site" always have unchecked checkmark in the dialog and don't remember if user have checked it.
The pull request saves/read the settings user have made when dialog is opend again.