Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMSUSD-1285 fix all test that relied on syncolor #3763

Merged
merged 2 commits into from
May 15, 2024

Conversation

pierrebai-adsk
Copy link
Collaborator

@pierrebai-adsk pierrebai-adsk commented May 10, 2024

Update the baseline images. Change the name of one color transform.
Disable one test in 2022 and 2024 that I cannot repro locally.
Added images for Maya 2022.

Update the baseline images. Change the name of one color transform.
Disable a few test in 2022 and 2024 that I cannot repro locally.
(The new images really are the old images before the syncolor/OpenImageIO fixes.)
@pierrebai-adsk pierrebai-adsk self-assigned this May 10, 2024
@pierrebai-adsk pierrebai-adsk added the adsk Related to Autodesk plugin label May 10, 2024
@pierrebai-adsk pierrebai-adsk changed the title EMSUSD-1285 re-enable some test on Maya 2022 with new images EMSUSD-1285 fix all test that relied on syncolor May 10, 2024
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll add @JGamache-autodesk to have a look.

Copy link
Collaborator

@JGamache-autodesk JGamache-autodesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pierrebai-adsk pierrebai-adsk added the ready-for-merge Development process is finished, PR is ready for merge label May 14, 2024
@seando-adsk seando-adsk added unit test Related to unit tests (both python or c++) and removed adsk Related to Autodesk plugin labels May 15, 2024
@seando-adsk seando-adsk merged commit 66ebc3d into dev May 15, 2024
11 checks passed
@seando-adsk seando-adsk deleted the bailp/EMSUSD-1285/syncolor-on-2022 branch May 15, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge unit test Related to unit tests (both python or c++)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants