EMSUSD-1000 - Implement new Hierarchy Cmd. #3597
Conversation
| Ufe::InsertChildCommand::Ptr | ||
| UsdHierarchy::appendChildVerifyRestrictionsCmd(const Ufe::SceneItem::Ptr& child) | ||
| { | ||
| const auto childCmd = appendChildCmd(child); |
There was a problem hiding this comment.
A better and cleaner solution would be to create a new cmd that inherits from UsdUndoInsertChildCommand and in the new constructor check the restrictions and throw the exception.
| //! Check if the src and dst attributes are connected. | ||
| //! \return True, if they are connected. | ||
| MAYAUSD_CORE_PUBLIC | ||
| bool isConnected(const PXR_NS::UsdAttribute& srcUsdAttr, const PXR_NS::UsdAttribute& dstUsdAttr); |
There was a problem hiding this comment.
Moving it to usdUfe/ufe as I see this function doesn't need the maya and mayaUsd .h included in lib/mayaUsd/ufe/Utils.h
| //! Check if the usdItem is connected (i.e. if there are in or out connections). | ||
| //! \return True, if it is connected. | ||
| USDUFE_PUBLIC | ||
| bool isConnected(const UsdSceneItem::Ptr& usdItem); |
There was a problem hiding this comment.
Moving out this function from LookdevXUsd
| const auto childCmd = appendChildCmd(child); | ||
|
|
||
| if (childCmd && isConnected(downcast(child))) { | ||
| throw std::runtime_error("The node you're trying to move has connections."); |
There was a problem hiding this comment.
We should update this message according to the updated and approved UI linked in the related story
| if (childCmd && isConnected(downcast(child))) { | ||
| throw std::runtime_error("The node you're trying to move has connections."); | ||
| } |
There was a problem hiding this comment.
In your Ufe PR it states "Returns a null pointer if the restrictions are not observed." - but here you are throwing. It should be one of the. Either return nullptr here or in Ufe change the doc to state that it will throw runtime_error if the restrictions are not observed.
There was a problem hiding this comment.
I have a general comment about the need for this new method. The JIRA item mentions "modify Outliner code to not allow dropped items if they are connected". Where is this new method called from? Wouldn't users be able to override the restriction by simply calling appendChildCmd? Therefore was any thought given to adding the restriction to that existing method?
Notes: Implementing the new cmd added in UFE PR.
Marking this as a Draft PR as we will need it for next Maya release since it is breaking the Hierarchy interface by adding a new command. Pushing it to not lose progress and be ready to jump on it for the next release.
related JIRA ticket
The new command will allow us to not drop connected items in the Outliner. Please refer to the related story ticket for more details.