New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Mollie #976
base: develop
Are you sure you want to change the base?
Conversation
Fix bug where request_data and transaction_data is stored wrong Change locale in .env
This is really great work, but I think this should be split into multiple prs because merging big changes is usually just pain. Also it is harder to track changes later. Some changes as refactors or changing methods (warn -> warning) are not worth doing because this project doesn't have that much tests. Which means that repo owners would need to test these changes manually. This in result might decrease chance of your pr getting merged. I would split your pr into two: bug fixes and new payment gw. Everything else's I would throw out for better. Or keep as a separate refactor pr if you feel that this is really needed. Edit: Also this pr most probably won't be merged because it seems that you've run composer update (with composer v2, buy I might be wrong). And even if you've tested whole application by hand project maintainers need to find time to do the same which is counterproductive. Updating any package without testing application throughout might break it in the most unexpected places. |
@jorisvergeer Should this create a new payment option in the accounts setting? I only get the standard three when working off your commit? Please let me know if I have missed something. I've not done anything with different payment gateways yet, so this is new, and I'm looking to learn. I'd love there to be something for Braintree, which a client of mine uses. |
It should create a new one, but I only added it to the existing code that creates the required rows in the database. |
Adding Mollie was basically the same as dummy with some small tweaks. I did not have to change big parts. |
@justynpride, have you run installation process after applying this pr? Seeds which create payment gateways are only run on installation (or manually). |
@quentincaffeino You are correct. I've rerun the installation and the seeds have come through. Thanks! |
Is there anything blocking this from getting merged? I'm a new user of Attendize and happy to contribute to the project. |
While I was trying to add Mollie support, I found some bugs and other stuff I wanted to change.
Summarized in this PR: