PHP header method which is used by Wkhtml2pdf lib to download file doesn't work when using swoole; replaced with laravel response #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP header method which is used by Wkhtml2pdf lib to download file doesn't work when using swoole; replaced with laravel response
quentincaffeino
force-pushed
the
fix/download-tickets-with-laravel-response
branch
from
f6f1aa3
to
39e2d68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I was pushing this service to its limits and last thing I could do is to try using swoole with it. And it worked, mostly. Only thing I found broken is tickets downloading since Wkhtml2pdf uses header method that isn't supported by swoole. So here is a fix which works with and without swoole just by using laravel response object.