Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs #759

Closed
wants to merge 79 commits into from
Closed

Fix bugs #759

wants to merge 79 commits into from

Conversation

publicarray
Copy link
Contributor

Includes #741 and #744

Due to long standing open PRs. I'll be continuing to work on this branch but likely more for my use cases and won't separate the work into separate PRs, feel to cherry pick if the PR gets too long.

CristianDeluxe and others added 23 commits November 25, 2019 05:05
…for-tickets-next

# Conflicts:
#	app/Models/Ticket.php
remember that during install the .env.example file overrides the variables.
when single organiser mode is enabled
Only add quotes to specific environment variables
In the DB the tickets->description field is set to not allow null values.
strip tags conviently returns an empty string when the content is null and thus fixes the issue (Integrity constraint violation: Column 'description' cannot be null)
postEditOrganiserPageDesign
Newer faker versions are already compatable with new php versions (7.4)
public_path was called twice
@publicarray publicarray force-pushed the new_master branch 4 times, most recently from 45e2988 to 2d082c6 Compare February 24, 2020 07:12
The config/attedize was previously restructured
@johannac johannac added the bug Features or code that is not working correctly label Apr 20, 2020
Bumps [doctrine/dbal](https://github.com/doctrine/dbal) from 2.10.1 to 2.10.2.
- [Release notes](https://github.com/doctrine/dbal/releases)
- [Commits](doctrine/dbal@v2.10.1...2.10.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [omnipay/common](https://github.com/thephpleague/omnipay-common) from 3.0.2 to 3.0.3.
- [Release notes](https://github.com/thephpleague/omnipay-common/releases)
- [Commits](thephpleague/omnipay-common@v3.0.2...v3.0.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@johannac johannac changed the base branch from next to develop April 23, 2020 21:58
@publicarray
Copy link
Contributor Author

publicarray commented Apr 23, 2020

@johannac I think I can close this since the branches have diverged significantly. I don’t remember exactly but some of these have recently been fixed

@johannac
Copy link
Member

@publicarray Ok sure, that sounds like a good plan. #744 is resolved now and we can work on #741 as a standalone PR. Was there anything else in here worth keeping/moving to a new PR? What about the ticket CSS stuff?

@publicarray
Copy link
Contributor Author

True, the ticket generation is something I can put into a new PR. Until then I'll leave it open for now.

Bumps [laravel/framework](https://github.com/laravel/framework) from 6.18.2 to 6.18.11.
- [Release notes](https://github.com/laravel/framework/releases)
- [Changelog](https://github.com/laravel/framework/blob/7.x/CHANGELOG-6.x.md)
- [Commits](laravel/framework@v6.18.2...v6.18.11)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [symfony/dom-crawler](https://github.com/symfony/dom-crawler) from 5.0.5 to 5.0.8.
- [Release notes](https://github.com/symfony/dom-crawler/releases)
- [Changelog](https://github.com/symfony/dom-crawler/blob/master/CHANGELOG.md)
- [Commits](symfony/dom-crawler@v5.0.5...v5.0.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [stripe/stripe-php](https://github.com/stripe/stripe-php) from 7.27.3 to 7.30.0.
- [Release notes](https://github.com/stripe/stripe-php/releases)
- [Changelog](https://github.com/stripe/stripe-php/blob/master/CHANGELOG.md)
- [Commits](stripe/stripe-php@v7.27.3...v7.30.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@johannac johannac added enhancement Improve or enhance an existing feature and removed bug Features or code that is not working correctly labels May 12, 2020
@justynpride
Copy link
Contributor

Is there an eta on when the ticket generation css might be merged? Would love to know what the roadmap / progress is on some of the other pull requests such as the Laravel 7. I'm looking to jump into the project for various use cases I have.

@publicarray publicarray mentioned this pull request May 21, 2020
@publicarray
Copy link
Contributor Author

@justynpride I feel you. I've just pushed #798 so this PR can be closed.

Since the virus I'm no longer actively working for the events industry. #798 is probably my last PR here. Good Luck!

@justynpride
Copy link
Contributor

@publicarray So sorry to hear about the change in circumstances. As you note the virus has effectively killed off the events industry at this moment in time.

A huge thank you for making that new pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve or enhance an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants