If a vehicle ends up with a GotoLocation mission to an unreachable ti… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le, it will repeatedly try to find a path in every game tick. The vehicle will eventually get stuck and slow down the game by spamming pathfinding requests. (#563) Note that vehicles usually don't end up with a GotoLocation with an unreachable destination, but it's possible, i.e. if some road tiles on the way get destroyed after the mission is created. Other fixes: * Prevent a vehicle from side-stepping in order to avoid itself. Implementation notes: * Moved all adjustTarget* methods to a new class VehicleTargetHelper with a single method that dispatches based on vehicle type. * Note that it's now that caller's responsibility to set pickedNearest as needed. * Inverted some conditionals for clearer early returns. Manually verified these vehicles are un-stuck after this change: * #395 (comment) * #395 (comment) Run clang-format Run clang-format 4.0.0, which is the version used by Travis CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…le, it will repeatedly try to find a path in every game tick. The vehicle will eventually get stuck and slow down the game by spamming pathfinding requests. (OpenApoc#563)
Note that vehicles usually don't end up with a GotoLocation with an unreachable destination, but it's possible, i.e. if some road tiles on the way get destroyed after the mission is created.
Other fixes:
Implementation notes:
Manually verified these vehicles are un-stuck after this change:
Run clang-format
Run clang-format 4.0.0, which is the version used by Travis CI.