<Fix> evaluation dataset, printed samples #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Atcold
reviewed
Jan 5, 2023
| @@ -497,7 +497,7 @@ | |||
| "\n", | |||
| " with torch.no_grad():\n", | |||
| " for batch_idx in range(len(data_generator)):\n", | |||
| " data, target = test_data_gen[batch_idx]\n", | |||
| " data, target = data_generator[batch_idx]\n", | |||
There was a problem hiding this comment.
We want to inspect sequences from the test set, no?
I didn't get it.
There was a problem hiding this comment.
Then why are we declaring the "data_generator", with a different seed, and not using it to sample data?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bunch of minor "theoretical" changes in the evaluation function:
test_data_genwas used as the data generator in the evaluation, instead ofdata_generator, thereby evaluating the net on the test set used for training (not an actual issue here given the sequences are randomized and not sampled from existing datasets, but in principle would lead to a data leak in realistic scenarios);correctsequences printed were a sampling (with reinsertion) of the first 10 evaluated, instead of 10 sampled from the whole set of correct ones;verbose==False, independently of their actual presence;