Skip to content
This repository has been archived by the owner on Mar 7, 2023. It is now read-only.

Astrabit-ST/ModShot-Core

 
 

Repository files navigation

Why is this archived?

ModShot is a mess. Really! If you go back in the git history, you'll see that a lot of lines of code originate from this commit: 0954cfd039e1de59a0cb84cac611c398e2d02a21

Why?

¯\_(ツ)_/¯

This is not the worst example I could point out by the way! There's so so many others but theyr equire an understanding of C++. The whole codebase is like this, ModShot is an unstable mess- nevermind that mkxp was already really unstable!

Speaking as Lily, ModShot's main contributor, I no longer have the willpower to maintain this dumpster fire. It was genuinely contributing to my depression last year. If you knew me around June-December of 2022, you'd know that I was borderline suicidal at times. Yeah, it was that bad. In the interest of my mental health, I gave up working on ModShot, and it's been left here to sit and rot.

I'll be honest, ModShot is really not my project. A lot of the stuff here was made by @rkevin-arch. Back when this started to be a thing, I knew nothing about C++, or Ruby for that matter. Only a few months earlier, I had actually gotten a book about learning to code in Python, because I really did not know anything.

rkevin basically carried the repo from a fork of mkxp-oneshot to what it is now, adding most of the features (such as ruby gem support and audio channels) that we take for granted. The only contribution I've really made was overhauling the build system, and even then, that was not a super big change.

I've thrown this whole codebase, all of rkevin's work really- into the dumpster, and that's not right.

So, I'll be leaving this as the last commit on the repo. A credit to rkevin, the guy who you should really be crediting for creating ModShot!

If you want an alternative, please take a look at @thehatkid's mkp-z fork: ModShot-mkxp-z

On a more positive note, me and @somedevfox have been working on a rust rewrite on and off for a while now, and we'll be devoting our time to getting up to feature parity with ModShot in the near future, so keep your eyes peeled!

ModShot-Core

ModShot CI

ModShot is a even more MORE specialized fork of a specialized fork of (mkxp by Ancurio designed for OneShot) for OneShot mods.

Thanks to hunternet93 for starting the reimplementation of the journal program!

Thanks to rkevin-arch for the docker build!

Thanks to somedevfox for helping ModShot ditch conan!

Thanks to hat_kid for fixing a lot such as wallpaper bindings, unicode Win32 username issue, and introducing Win32 tray ballons and GTK notifications!

mkxp is a project that seeks to provide a fully open source implementation of the Ruby Game Scripting System (RGSS) interface used in the popular game creation software "RPG Maker XP", "RPG Maker VX" and "RPG Maker VX Ace" (trademark by Enterbrain, Inc.), with focus on Linux. The goal is to be able to run games created with the above software natively without changing a single file.

It is licensed under the GNU General Public License v2+.

ModShot also makes use of steamshim for GPL compliance while making use of Steamworks features. See LICENSE.steamshim.txt for details. You can compile ModShot with steam without compiling steamshim, but you will need to source the steamshim binary yourself.

Building

Conan is no longer supported. Long live conan. Instead, ModShot now makes use of meson, bash, and make, in a fairly simple setup. You only need to compile dependencies once.

Because of this, compiling with Visual Studio as was standard before is no longer supported, and instead compiling using the msys2 toolset is required. The main upshot of this, of course, is remaining on par with ruby in terms of gem support. (at least for windows)

Previously, C extensions were very jank with ModShot, however now you can use a C extension right from your own Ruby install! (Provided the version is the same, and the msys2 evironment is the same. I'll get back to this later.)

Using clang

//TODO

FMOD

FMOD support is very... interesting. It involves a lot of licensing, legalese, etc. If you want to enable FMOD support, download FMOD and extract the zip into a folder named fmod. You will then need to pass -Dfmod=true as an option.

ModShot should handle everything from there, it's up to you to follow the FMOD license.

FMOD bindings also do not supply the Audio module. You may create wrapper functions for that if you wish. AL Effect bndings are not supplied as well for obvious reasons.

Functions will always return an array of values (usually two) in the order of [result, values...]. This means you can do result, value = FMOD.some_func(), which is pretty neat, right? If a result is not FMOD_OK (0) there will be no return value. Keep that in mind!

The FMOD bindings won't hold your hands either- You will need to clean up after yourself. Because of the way the bindings work as well calling the same function twice will NOT return the "same" object. Fundamentally, it is the same object, as the C++ side object is the same, but it is a brand new object as far as ruby is concerned.

Because of this behavior, you can quite easily cause a memory leak by repeatedly storing an object returned in an array somewhere constantly loaded such that ruby will not garbage collect it. i.e

array = []
100000.times do
    array << bank.get_event_list # Bad will memory leak!
end

So, be mindful of what you write! Luckily instances of objects from these bindings are very small so it's not a big deal if your code isn't perfect, but PLEASE do be mindful of this! RMXP already has a similar problem with Bitmaps, so if you've dealt with them you should know what to do. There is an == operator provided that will check if an object is the same for you as well. You can usually assign a value nil to get it garbage collected.

A feature is provided to automatically release some FMOD objects (Like System, Bank, etc) but it is disabled by default. This is because some FMOD functions will allow you to "get back" an object after it has been garbage collected from ruby, and this feature messes with that. I would not suggest using it because if you are, you're likely doing something wrong and are relying on a bandaid fix to avoid it being an issue.

The bindings should generally line up with what's documented in the latest FMOD docs- although things like FMOD_Studio_System_Create are hidden away under FMOD::Studio::System.new instead. The bindings are closest to the C# bindings for FMOD.

Plugins are potentially supported via C extensions but if you really want to add support for one you may hardcode it in. Something like ResonanceAudio would be simple enough, since all you would need to do is wrap a struct like mkxp wraps classes, and the FMOD bindings here should do the rest. It'll pull a void pointer to your wrapped data by using getPrivateData<void*>. Getting data back like this will either convert it to a string, or the user will pass in a class that the bindings will set the data of. I still haven't decided on how to do this just yet, though, but I am leaning towards the string method.

One other thing to note is that with structs you need to be mindful of method chaining. You can chain methods on the struct (like struct.position.y = 15) but if chained on the return vaue from a method it won't work.

# will not work!
eventinstance.get_3d_attributes[1].up.x = 15
# will work!
struct = eventinstance.get_3d_attributes[1]
struct.up.x = 15
eventinstance.set_3d_attributes(struct)

I hope that's enough info to get you started! There will be some direct conversions of FMOD examples in the scripts folder when I get to it. (TODO)

Options

RUBY_VER && -Dmri_version (default 3.1) sets the ruby version.
-Dsteam (default false) sets the build to use steam.
--build-type (default Release) sets the build type.
-Dbuild_static (default true) sets the build to be static. (True is faster, but with longer startup times.)
-Dfmod (default false) toggles FMOD instead of OpenAL.
-Dauto_clean_fmod (default false) toggles auto releasing SOME FMOD objects when garbage collected.

Building on Windows

First, you'll need to download msys2 and install it. Then, you'll want to determine what Ruby version you're using, as this will determine what build environment you'll be using. As is, ModShot is set up to use Ruby 3.1, so keep that in mind. Please refer to this table to determine the environment. (You can use the wrong environment and it will work fine, just not with C extensions.)

Ruby >3.1 UCRT64 (Default)
Ruby 3.0-2.0 MINGW64
Ruby <1.9 MINGW32 (NOT SUPPORTED!)

Once you've figured out the environment you need to use, pull up an msys2 shell of it. (You can search the environment name in the Windows search box to open it) From there, it's pretty much identical to the Linux setup.

# Install dependencies from package manager
sh setup.sh

# Build extra dependencies (like ruby)
cd windows; make
source vars.sh

cd ..; meson build --prefix="$PWD/build.out" --bindir=.
cd build && ninja install

Building on Linux

Building on Linux is fairly easy, as long as you're using one of the supported distros. (Manjaro, Debian/Ubuntu, Fedora/Red Hat) Unlike Windows, you don't have to worry about msys2 environments. Just use gcc and you'll be good to go. If you're not, fear not, as you can usually just install all the dependencies right from your package manager. See setup.sh.

# Install dependencies from package manager
sh setup.sh

# Build extra dependencies (like ruby)
cd linux; make
source vars.sh

cd ..; meson build --prefix="$PWD/build.out" --bindir=.
cd build && ninja install

This should create a folder called out with your build of ModShot all ready to go!

Configuration

ModShot reads configuration data from the file "oneshot.conf". The format is ini-style. Do not use quotes around file paths (spaces won't break). Lines starting with '#' are comments. See 'oneshot.conf.sample' for a list of accepted entries.

All option entries can alternatively be specified as command line options. Any options that are not arrays (eg. preloaded scripts) specified as command line options will override entries in oneshot.conf. Note that you will have to wrap values containing spaces in quotes (unlike in oneshot.conf).

The syntax is: --<option>=<value>

Example: ./oneshot --gameFolder="oneshot" --vsync=true

External gems

Modshot builds come pre-packaged with the ruby standard library in /lib/ruby/. You can require gems from this folder at any point by using require '<gem>'.

You can ship your own gems by finding the gem install location (Typically C:\Ruby27-x64\lib\ruby\gems\2.7.0\gems), going inside the gem, and copying over all the files inside lib.

About

A fork of mkxp, forked for OneShot, forked for OneShot mods, (not to be confused with the ModShot server)

Resources

License

Stars

Watchers

Forks

Packages

No packages published

Languages

  • C++ 52.5%
  • Ruby 40.1%
  • C 3.6%
  • GLSL 1.1%
  • Meson 0.8%
  • Shell 0.8%
  • Other 1.1%