large screen support (WIP) #560

abcghy · 2024-01-23T04:54:10Z

issue: #338

Guideline: https://developer.android.com/jetpack/compose/layouts/adaptive
Official Reference: https://github.com/android/compose-samples/tree/main/JetNews
Design Reference: https://m3.material.io/foundations/layout/canonical-layouts/list-detail

JunkFood02 · 2024-01-23T16:09:53Z

FYI: Compose Material3 Adaptive Version

Ashinch · 2024-01-23T16:19:26Z

Maybe we can wait for #502 to be merged before we start this work?

At present, the compose version on the main branch is far behind.

Or create a dev branch for experimental functions based on #502.

I'm not sure when 0.9.12 will be released. There are still some problems with Google Reader API integration. I'm worried that #502 will wait too long, so that the new features will not be start.

mbestavros · 2024-01-30T06:05:34Z

@Ashinch If delaying @JunkFood02's Compose update (#502) is holding community development back, why not merge it now? Especially if Greader needs a bit more time to cook as well.

Ashinch · 2024-01-30T07:48:34Z

@Ashinch If delaying @JunkFood02's Compose update (#502) is holding community development back, why not merge it now? Especially if Greader needs a bit more time to cook as well.

Hi, @mbestavros

Google Reader API does indeed need some improvement time. Do you have any suggestions? For example, creating a new dev branch to merge these PRs, allowing the new PRs to continue development using the dev branch，after stabilizing, merge the dev branch back into the main branch? 🤔

Ashinch · 2024-01-30T07:51:31Z

@Ashinch If delaying @JunkFood02's Compose update (#502) is holding community development back, why not merge it now? Especially if Greader needs a bit more time to cook as well.

Hi, @mbestavros

Google Reader API does indeed need some improvement time. Do you have any suggestions? For example, creating a new dev branch to merge these PRs, allowing the new PRs to continue development using the dev branch，after stabilizing, merge the dev branch back into the main branch? 🤔

The reason for blocking #502 is that it involves a significant dependency upgrade, and I'm not sure if the UI will work properly. Currently, I'm dealing with issues related to the Google Reader API, so I might not have time to migrate the changes brought by #502.

JunkFood02 · 2024-01-30T11:18:24Z

not sure if the UI will work properly

Have been using the app with latest Compose for a while (not much!), and I didn't see any noticeable glitch or bug in it. To be honest, since stable release (v1.0) is still far ahead, users should be more open to help test potential issues as long as there're still updates and fixes

Ashinch · 2024-02-22T08:55:33Z

Hi, @abcghy

Could you please help resolve a code conflict? I think some of our infrastructure is now ready.

Ashinch · 2024-03-08T04:14:45Z

Hi, everyone.

What is the current status of this PR?

Has anyone else tried it yet?

I want to know if it can be merged. ☺️

JunkFood02 · 2024-03-08T04:29:57Z

I've just reviewed this implementation before. It's a rather simple walkaround for large screen support, but lack of handling many corner cases, like rotating the screen or system navigation. Anyway, existing users(compact screen width) shouldn't be affected by this change, so I'm approving it

JunkFood02 · 2024-03-08T04:37:02Z

app/src/main/java/me/ash/reader/infrastructure/android/MainActivity.kt

@@ -82,7 +86,7 @@ class MainActivity : AppCompatActivity() {
                                removeOnNewIntentListener(listener)
                            }
                        }
-                        HomeEntry(subscribeViewModel = subscribeViewModel)
+                        HomeEntry(subscribeViewModel = subscribeViewModel, widthSizeClass = widthSizeClass)


Use CompositionLocal instead of a explicit parameter seems neater

JunkFood02 · 2024-03-08T04:39:46Z

app/src/main/java/me/ash/reader/ui/page/common/HomeEntry.kt

                )
            }
            forwardAndBackwardComposable(route = "${RouteName.READING}/{articleId}") {
-                ReadingPage(navController = navController, homeViewModel = homeViewModel)
+                ReadingPage(navController = navController, homeViewModel = homeViewModel, isExpandedScreen = isExpandedScreen)


TODO: handle system navigations & screen orientation changes

@JunkFood02 Could you elaborate on this one? Currently I only added a FlowRoute so that it can react to different width, that include the screen orientation changes.

Sure! The FlowWithArticleDetailsScreen consists of two destination: a flow view and an article reader screen.

When rotating from expanded to compact width with an article open, the user will be taken back to the flow screen instead of switching to a full-screen article reader. This also happens in landscape mode when trying to navigate back from the article reader.

This issue is addressed in the blog post of Compose team, maybe you can get some inspirations at the part of "Preserving the user’s state through screen size changes" 🤞

Ashinch · 2024-03-08T05:21:01Z

Okay, please remind me when this PR is ready.

abcghy · 2024-03-29T17:01:07Z

added isArticleOpen and articleId in HomeUiState.
Combine Reading Page with Flow Page into FlowRoute. So that we can determine which page to show according to screen width and isArticleOpen.
Removed Reading Page from navigation due the reason above.

@JunkFood02

JunkFood02 · 2024-03-30T13:02:17Z

app/src/main/java/me/ash/reader/ui/page/home/flow/FlowRoute.kt

+                onArticleClick = selectArticle,
+            )
+        }
+        FlowScreenType.ArticleDetails -> {


The Article -> Flow -> Home backstack seems broken now

Anyway, we can put this change on hold since even Google haven't agree on the pattern of making a adaptive navigation

The Article -> Flow -> Home backstack seems broken now

Could you please elaborate on the work flow?

abcghy marked this pull request as draft January 23, 2024 07:28

abcghy force-pushed the fix/large-screen-support branch from 656fd3c to b24c039 Compare January 23, 2024 07:40

Ashinch changed the base branch from main to dev January 30, 2024 17:27

Ashinch marked this pull request as ready for review January 30, 2024 17:28

Ashinch requested a review from JunkFood02 January 30, 2024 17:28

JunkFood02 self-assigned this Jan 31, 2024

Ashinch changed the base branch from dev to main February 6, 2024 17:37

Ashinch added this to the 0.9.13 milestone Feb 22, 2024

Ashinch mentioned this pull request Feb 22, 2024

adding support large screens #497

Open

abcghy force-pushed the fix/large-screen-support branch from 91cf190 to 50b4054 Compare February 25, 2024 16:11

JunkFood02 approved these changes Mar 8, 2024

View reviewed changes

abcghy force-pushed the fix/large-screen-support branch from 50b4054 to f5193c8 Compare March 29, 2024 16:47

feat(ui): large screen support

8a0eda1

abcghy force-pushed the fix/large-screen-support branch from f5193c8 to 8a0eda1 Compare March 29, 2024 16:51

JunkFood02 self-requested a review March 29, 2024 17:48

JunkFood02 requested changes Mar 30, 2024

View reviewed changes

shuvashish76 mentioned this pull request Apr 17, 2024

Please Add Tablet Support #656

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

large screen support (WIP) #560

large screen support (WIP) #560

abcghy commented Jan 23, 2024

JunkFood02 commented Jan 23, 2024

Ashinch commented Jan 23, 2024

mbestavros commented Jan 30, 2024

Ashinch commented Jan 30, 2024

Ashinch commented Jan 30, 2024

JunkFood02 commented Jan 30, 2024 •

edited

Ashinch commented Feb 22, 2024

Ashinch commented Mar 8, 2024

JunkFood02 commented Mar 8, 2024 •

edited

JunkFood02 Mar 8, 2024

JunkFood02 Mar 8, 2024

abcghy Mar 27, 2024

JunkFood02 Mar 28, 2024 •

edited

Ashinch commented Mar 8, 2024

abcghy commented Mar 29, 2024

JunkFood02 Mar 30, 2024

JunkFood02 Mar 30, 2024

abcghy Mar 31, 2024

large screen support (WIP) #560

Are you sure you want to change the base?

large screen support (WIP) #560

Conversation

abcghy commented Jan 23, 2024

JunkFood02 commented Jan 23, 2024

Ashinch commented Jan 23, 2024

mbestavros commented Jan 30, 2024

Ashinch commented Jan 30, 2024

Ashinch commented Jan 30, 2024

JunkFood02 commented Jan 30, 2024 • edited

Ashinch commented Feb 22, 2024

Ashinch commented Mar 8, 2024

JunkFood02 commented Mar 8, 2024 • edited

JunkFood02 Mar 8, 2024

Choose a reason for hiding this comment

JunkFood02 Mar 8, 2024

Choose a reason for hiding this comment

abcghy Mar 27, 2024

Choose a reason for hiding this comment

JunkFood02 Mar 28, 2024 • edited

Choose a reason for hiding this comment

Ashinch commented Mar 8, 2024

abcghy commented Mar 29, 2024

JunkFood02 Mar 30, 2024

Choose a reason for hiding this comment

JunkFood02 Mar 30, 2024

Choose a reason for hiding this comment

abcghy Mar 31, 2024

Choose a reason for hiding this comment

JunkFood02 commented Jan 30, 2024 •

edited

JunkFood02 commented Mar 8, 2024 •

edited

JunkFood02 Mar 28, 2024 •

edited