Solution Rebasing #545
Open
Solution Rebasing #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apps/arweave/src/ar_block_cache.erl
Outdated
| %-type validation_status() :: on_chain | validated | not_validated | none. | ||
| %-type nonce_limiter_validation_status() :: nonce_limiter_validated | | ||
| % nonce_limiter_validation_scheduled | awaiting_nonce_limiter_validation. | ||
| %-type block_status() :: validation_status() | {not_validated, nonce_limiter_validation_status()}. |
There was a problem hiding this comment.
you can just delete those if you want. I'd added them when I was trying to undesr the ar_block_cache for the checkpoint work. Probably not useful as a one-off
apps/arweave/src/ar_node_worker.erl
Outdated
| @@ -1026,10 +740,10 @@ get_block_anchors_and_recent_txs_map(BlockTXPairs) -> | |||
| apply_block(State) -> | |||
| case ar_block_cache:get_earliest_not_validated_from_longest_chain(block_cache) of | |||
| not_found -> | |||
| %% Nothing to do - we are at the longest known chain already. | |||
| {noreply, State}; | |||
| may_be_rebase(State); | |||
There was a problem hiding this comment.
Suggested change
| may_be_rebase(State); | |
| maybe_rebase(State); |
JamesPiechota
approved these changes
Apr 12, 2024
ldmberman
force-pushed
the
improvement/block-rebase
branch
from
4fb89c0
to
c6ca466
Compare
|
@JamesPiechota FYI I pushed c6ca466 on top of previously reviewed. UPD nevermind, a similar change was in master already. |
ldmberman
force-pushed
the
improvement/block-rebase
branch
from
c6ca466
to
c019a74
Compare
@ldmberman got it. let me know if you need me to re-review |
ldmberman
force-pushed
the
improvement/block-rebase
branch
from
c019a74
to
0f08048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.