Return specific error codes for failed txs #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmellen
approved these changes
Nov 13, 2019
src/ar_tx.erl
Outdated
| ar_wallet:verify(TX#tx.owner, signature_data_segment(TX), TX#tx.signature)} | ||
| ], | ||
| ] ++ tx_field_size_limit(TX, Height), |
There was a problem hiding this comment.
I'd maybe pluralize that function name since it now returns a list of limits
ldmberman
force-pushed
the
improvement/api-tx-validation-error-codes
branch
from
3bb47ba
to
04cce3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The network does not depend on this API, but we need to check if
arweave-jsand browser extensions need updating and talk to Upvest.