Adjustments for upstream upgrades #253
Conversation
|
A fix is identified already and will lead to a new PyMuPDF version - hopefully even today. |
|
Thanks Train! ( hope you don't me calling you "Train" - seen you use it a few times, please let me know ) . It is possible that we will have fixed some of the issues you are seeing in an imminent release of PyMuPDF. Adding Harald & Julian here as they should be aware of the behaviour change for |
|
@jamie-lemon "Train" sounds friendly for me, as it's a name used in my college time. 😁 Regarding this PR, once released PyMuPDF 1.23.16, I just need to delete the version restriction in requirements.txt, the rest should be OK. |
pdf2docx/common/Element.py
Outdated
| factor (float, optional): Threshold of overlap ratio, the larger it is, the higher | ||
| probability the two bbox-es are aligned. | ||
| text_direction (bool, optional): Consider text direction or not. | ||
| True by default,from left to right if False. |
There was a problem hiding this comment.
I don't really understand what this means "True by default, from left to right if False".
So if the text_direction is True then we do consider text direction - okay, but if it is False then we don't consider text directions, however when I read this it seems like False means we consider a left to right text direction as it says "from left to right if False". I'm confused!
There was a problem hiding this comment.
I didn't read any contradictions between your thoughts -> don't consider text directions -> ignore real text directions -> use default text directions -> the most common case, horizontal, i.e., from left to right.
Appreciated if you help a precise wording.
There was a problem hiding this comment.
Per my understanding, don't consider text directions, means to use default text direction, which is from left to right.
There was a problem hiding this comment.
I suppose the bit I don't understand then is if True then what is the text direction? Basically:
False = from left to right
True = ?
Also if we are False then we do consider the text direction don't we (left to right)? Which is why text_direction (bool, optional): Consider text direction or not. confuses me!
There was a problem hiding this comment.
I probably understand your confusion. When False, the words from left to right does not mean to text direction, but the default direction for "horizontal". I should just keep True by default and delete the rest.
There was a problem hiding this comment.
Okay - yes please just delete to avoid the confusion.
pdf2docx/common/Element.py
Outdated
| factor (float, optional): threshold of overlap ratio, the larger it is, the higher | ||
| probability the two bbox-es are aligned. | ||
| text_direction (bool, optional): consider text direction or not. | ||
| True by default, from left to right if False. |
There was a problem hiding this comment.
See previous comment.
|
FYI, PyMuPDF-1.23.16 has just been released, and fixes the Pixmap issue pymupdf/PyMuPDF#3058. The fitz.Rect problem was introduced in 1.23.9 and fixed in 1.23.13 and later. Hope that helps. |
Some adjustments to handle the side effects of upgrading
PyMuPDFfrom 1.23.8 to 1.23.14+, e.g.,fitz.Rect()-> adjusted frompdf2docxside. 所有文字丢失：Ignore Line xx due to overlap. #250fitz.Pixmap()-> downgradepymupdffor now. Pixmap created from CMYK JPEG delivers RGB format pymupdf/PyMuPDF#3058And some other tweaks, e.g., remove Github Action for publishing docs to Github page.