Include nested classes in JAR file #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current configuration, nested classes, e.g. Context$Log.class are not included in the resulting JAR file. This is because files are explicitly included by name, and their name is derived from the existence of .java files, replacing the file ending with .class. However, inner class files like Context$Log.class are generated by the compiler, and don't have corresponding .java files. Not sure if simply replacing with "com", the root package name, is appropriate ,but it does work for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current configuration, nested classes, e.g.
Context$Log.classare not included in the resulting JAR file. This is because files are explicitly included by name, and their name is derived from the existence of.javafiles, replacing the file ending with.class. However, inner class files likeContext$Log.classare generated by the compiler, and don't have corresponding.javafiles.Not sure if simply replacing with
com, the root package name, is appropriate, but it does work for me.