Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically infer varchar column name #27

Open
wants to merge 1 commit into
base: version-4.0
Choose a base branch
from

Conversation

Arp-G
Copy link
Owner

@Arp-G Arp-G commented Oct 28, 2022

We must dynamically infer the column's varchar size by finding the max data size in that column.
So the varchar_limit the user specifies must only be used to decide when to switch from varchar to text.

Helps in fixing: #25

Also contains some minor cleanup and fixes.

@Arp-G
Copy link
Owner Author

Arp-G commented Oct 29, 2022

for empty columns set varchar(1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant