Correct behavior of the 'User Agent' menu. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gent was canceled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because check state of a menu item (QAction) cannot be controlled in a slot connected to the 'triggered' signal, if the user cancels the dialog for setting a custom user agent string, the 'Other...' item stays checked, which isn't optimal.
This patch corrects that behavior by remembering the previous checked item. This approach was necessary because QAction::data of the 'Default' item is always empty but WebPage::s_userAgent may be either empty or contain the value of QWebPage::userAgentForUrl.