Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(datasets): rename legacy datasets to inferences #3173

Merged
merged 8 commits into from
May 14, 2024
Merged

refactor(datasets): rename legacy datasets to inferences #3173

merged 8 commits into from
May 14, 2024

Conversation

mikeldking
Copy link
Contributor

resolves #3171

@mikeldking mikeldking changed the base branch from sql to datasets May 11, 2024 18:27
@mikeldking mikeldking marked this pull request as ready for review May 13, 2024 21:18
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label May 13, 2024
axiomofjoy
axiomofjoy reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@axiomofjoy axiomofjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a pass at the Python files, but there are a lot of missed references to datasets.

app/src/@types/dataset.d.ts Outdated Show resolved Hide resolved
src/phoenix/server/main.py Outdated Show resolved Hide resolved
src/phoenix/server/api/types/Event.py Outdated Show resolved Hide resolved
src/phoenix/server/api/types/Model.py Outdated Show resolved Hide resolved
src/phoenix/server/api/types/Model.py Outdated Show resolved Hide resolved
src/phoenix/core/model_schema_adapter.py Outdated Show resolved Hide resolved
app/src/components/pointcloud/DatasetVisibilitySettings.tsx Outdated Show resolved Hide resolved
app/src/components/pointcloud/DatasetVisibilitySettings.tsx Outdated Show resolved Hide resolved
app/src/components/pointcloud/DatasetVisibilitySettings.tsx Show resolved Hide resolved
app/src/components/pointcloud/EventItem.tsx Show resolved Hide resolved
@mikeldking
parent 1238c1a
56f000b 
author Mikyo King <mikyo@arize.com> 1715451959 -0600
committer Mikyo King <mikyo@arize.com> 1715691349 -0600

refactor(datasets): rename legacy datasets to inferences

migrate python

schema

refactor the UI

refactor tests

more refactor

more refactor

more fix

WIP

pr comments

more python changes

more renaming

more refactor

more refactor

fix directory

refactor tests

final
axiomofjoy
axiomofjoy approved these changes May 14, 2024
View reviewed changes
app/src/@types/inferences.d.ts Outdated Show resolved Hide resolved
app/src/contexts/InferencesContext.tsx Outdated
null
);

export function useDatasets() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed here.

app/src/contexts/InferencesContext.tsx Outdated Show resolved Hide resolved
app/src/constants/pointCloudConstants.tsx Outdated Show resolved Hide resolved
app/src/pages/embedding/PointSelectionGrid.tsx Outdated Show resolved Hide resolved
app/src/pages/embedding/PointSelectionTable.tsx Outdated Show resolved Hide resolved
app/src/components/pointcloud/PointCloudPointTooltip.tsx Outdated Show resolved Hide resolved
@mikeldking mikeldking merged commit f6fefd4 into datasets May 14, 2024
12 checks passed
@mikeldking mikeldking deleted the 3171-datasets-rename branch May 14, 2024 16:52
mikeldking added a commit that referenced this pull request May 14, 2024
@mikeldking
refactor(datasets): rename legacy datasets to inferences (#3173)
143bb8b 
* parent 1238c1a
author Mikyo King <mikyo@arize.com> 1715451959 -0600
committer Mikyo King <mikyo@arize.com> 1715691349 -0600

refactor(datasets): rename legacy datasets to inferences

migrate python

schema

refactor the UI

refactor tests

more refactor

more refactor

more fix

WIP

pr comments

more python changes

more renaming

more refactor

more refactor

fix directory

refactor tests

final

* gql

* Rename

* more refactor

* package.json

* final refactor

* fix comment

* prettier
@axiomofjoy axiomofjoy mentioned this pull request May 16, 2024
Closed
mikeldking added a commit that referenced this pull request May 21, 2024
@mikeldking
refactor(datasets): rename legacy datasets to inferences (#3173)
a5e0f31 
* parent 1238c1a
author Mikyo King <mikyo@arize.com> 1715451959 -0600
committer Mikyo King <mikyo@arize.com> 1715691349 -0600

refactor(datasets): rename legacy datasets to inferences

migrate python

schema

refactor the UI

refactor tests

more refactor

more refactor

more fix

WIP

pr comments

more python changes

more renaming

more refactor

more refactor

fix directory

refactor tests

final

* gql

* Rename

* more refactor

* package.json

* final refactor

* fix comment

* prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axiomofjoy axiomofjoy axiomofjoy approved these changes

Assignees
No one assigned
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
phoenix
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikeldking @axiomofjoy