Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update common-mount-targeting.rst to describe mapping of mounts #5995

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

timtuxworth
Copy link
Contributor

Mapping of MNT mounts to specific physical devices is a bit tricky. This tries to explain it.

Mapping of MNT mounts to specific physical devices is a bit tricky. This tries to explain it.
Added additional info provided by Randy
@Hwurzburg Hwurzburg requested a review from rmackay9 May 17, 2024 00:09
common/source/docs/common-mount-targeting.rst Outdated Show resolved Hide resolved
common/source/docs/common-mount-targeting.rst Outdated Show resolved Hide resolved
@rmackay9
Copy link
Contributor

.. maybe we should just fix the code so that it works like rangefinders..

@timtuxworth
Copy link
Contributor Author

.. maybe we should just fix the code so that it works like rangefinders..

I'm guessing that's a bigger deal, but also a good idea. Assuming that might take a while I'm thinking it probably makes sense to update the wiki in the meantime.

Read the code to try to figure out how this works and updated accordingly.
Clarified a bit more about non servo/serial/net gimbals
"such as including" was a bit awkward
@timtuxworth
Copy link
Contributor Author

Are you sure that multiple serial/net gimbals can be used @rmackay9 - looking at the code in find_serial() -> find_protocol_instance() it seems to me that it might not work, i.e.

You might only be able to have 2 gimbals if they are different types - i.e. a serial gimbal + a servo/gremsy/solo... but not two serial type gimbals like the siyi, alexmos, viewpro ...

Do I have it wrong?

@rmackay9
Copy link
Contributor

rmackay9 commented May 18, 2024

@timtuxworth,

Ah,, darn. You are right. The line here should be using the instance number instead of "0". The equivalent line is also incorrect in the SToRM32_serial and Viewpro drivers :-(

Thank you very much for finding this. We will fix it! Or you could probably fix if you want. No pressure.

I've created an issue here ArduPilot/ardupilot#27090

@rmackay9
Copy link
Contributor

Hi @timtuxworth,

I've created a flight code PR ArduPilot/ardupilot#27129 that fixes the underlying issue (at least in my light testing) it does. Hopefully we will be able to get this merged and backported to a beta in the near-ish future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants