Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Castlevania: Circle of the Moon - Implement New Game #3299

Open
wants to merge 52 commits into
base: main
Choose a base branch
from
Open

Castlevania: Circle of the Moon - Implement New Game #3299

wants to merge 52 commits into from
+3,984 −0

Conversation

LiquidCat64
Copy link
Contributor

What is this fixing or adding?

Adds Castlevania: Circle of the Moon as a supported Archipelago game.
Adapted from the standalone randomizer by @calm-palm here: https://github.com/calm-palm/cotm-randomizer

How was this tested?

Many playtests by me and others who have been playing it unsupported in their multis.

If this makes graphical changes, please attach screenshots.

Screenshot 2024-05-14 035937
Screenshot 2024-05-14 040141

LiquidCat64 and others added 30 commits March 17, 2024 03:28
@LiquidCat64
Add the cotm package with working seed playthrough generation.
44ef8e1
@LiquidCat64
Add the proper event flag IDs for the Item codes.
e50de62
@LiquidCat64
Oooops. Put the world completion condition in!
84ae797
@LiquidCat64
Merge branch 'ArchipelagoMW:main' into CotM
bca58a9
@LiquidCat64
Adjust the game name and abbreviations.
995ef6f
@LiquidCat64
Merge remote-tracking branch 'catipelago/CotM' into CotM
83250b3
@LiquidCat64
Implement more settings.
2318fac
@LiquidCat64
Account for too many start_inventory_from_pool cards with Halve DSS C…
a81eca8 
…ards Placed.
@LiquidCat64
Working (albeit very sloooooooooooow) ROM patching.
eceb68a
@LiquidCat64
Merge branch 'ArchipelagoMW:main' into CVCotM
ae4bc32
@LiquidCat64
Merge branch 'ArchipelagoMW:main' into CVCotM
cc79a6b
@LiquidCat64
Screw you, bsdiff! AP Procedure Patch for life!
75aeb1d
@LiquidCat64
Nuke stage_assert_generate as the ROM is no longer needed for that.
220ad44
@LiquidCat64
Working item writing and position adjusting.
70ab3a3
@LiquidCat64
Merge branch 'ArchipelagoMW:main' into CVCotM
8d5f1a5
@LiquidCat64
Fix the magic item graphics in Locations wherein they can be fixed.
f2635b6
@LiquidCat64
Enable sub-weapon shuffle
07b4f62
@LiquidCat64
Get the seed display working.
921e158
@LiquidCat64
Get the enemy item drop randomization working. Phew!
fef3d14
@LiquidCat64
Enemy drop rando and seed display fixes.
856a250
@LiquidCat64
Functional Countdown + Early Double setting
55a7f8d
@LiquidCat64
Working multiworld (yay!)
a11edd2
@LiquidCat64
Fix item links and demo shenanigans.
f40fb33
@LiquidCat64
Merge branch 'ArchipelagoMW:main' into CVCotM
94d588d
@LiquidCat64
Add Wii U VC hash and a docs section explaining the rereleases.
6984c74
@LiquidCat64
Change all client read/writes to EWRAM instead of Combined WRAM.
6e81abc
@LiquidCat64
Custom text insertion foundations.
c62a78c
@LiquidCat64
Merge branch 'ArchipelagoMW:main' into CVCotM
55121ac
@LiquidCat64
Working text converter and word wrap detector.
d85d9ba
@LiquidCat64
Merge branch 'ArchipelagoMW:main' into CVCotM
1b450f3
@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels May 14, 2024
ScipioWright
ScipioWright reviewed May 14, 2024
View reviewed changes
worlds/cvcotm/__init__.py Outdated Show resolved Hide resolved
worlds/cvcotm/docs/en_Castlevania - Circle of the Moon.md Outdated Show resolved Hide resolved
worlds/cvcotm/items.py Outdated Show resolved Hide resolved
worlds/cvcotm/locations.py Outdated Show resolved Hide resolved
worlds/cvcotm/presets.py Outdated Show resolved Hide resolved
worlds/cvcotm/presets.py Outdated Show resolved Hide resolved
worlds/cvcotm/presets.py Outdated Show resolved Hide resolved
@ScipioWright ScipioWright added the is: new game Pull requests for implementing new games into Archipelago. label May 14, 2024
@LiquidCat64
Copy link
Contributor Author

NamedTuple classes are now in use for the Items and Locations tables and I removed the DeathLink and 0 Progression Balancing from the presets that had a chance for them. Also touched up a few things in the Game Page.

ScipioWright
ScipioWright approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good (as to be expected from someone who already has a game in). Test gens worked out perfectly, conflicting options resolve in a reasonable way.
I did not test the client.

worlds/cvcotm/options.py Outdated Show resolved Hide resolved
worlds/cvcotm/options.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScipioWright ScipioWright ScipioWright approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: new game Pull requests for implementing new games into Archipelago. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LiquidCat64 @ScipioWright