CommonClient: allow worlds to change title of run_gui without rewriting it #3297
+10
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted to the normal default so others using it don't have to rewrite everything
github-actions
bot
added
affects: core
|
updated description to reflect the new design |
beauxq
reviewed
May 14, 2024
treble suggestion 1 Co-authored-by: Aaron Wagener <mmmcheese158@gmail.com>
treble suggestion 2 Co-authored-by: Aaron Wagener <mmmcheese158@gmail.com>
treble suggestion 3 Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com>
|
whoops, didn't notice until i pressed the button that one of those wasn't a treble suggestion lol |
alwaysintreble
approved these changes
May 14, 2024
nicholassaylor
approved these changes
May 14, 2024
Exempt-Medic
added
the
is: enhancement
ScipioWright
added
waiting-on: core-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
moves GameManager to an optional attribute that worlds can update or overwrite as needed
How was this tested?
ran text client with the change, saw no issues,
updated my client to not define run_gui and use
self.ui_manager.base_title = "Minit Client"in the init instead and ran it, saw no issuesIf this makes graphical changes, please attach screenshots.