Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Remove deprecated get_current_option_name and SpecialRange #3296

Merged
merged 2 commits into from
May 17, 2024
Merged

Core: Remove deprecated get_current_option_name and SpecialRange #3296

merged 2 commits into from
May 17, 2024

Conversation

Exempt-Medic
Copy link
Collaborator

@Exempt-Medic Exempt-Medic commented May 13, 2024 •
edited

What is this fixing or adding?

Removing two deprecated things that can now be removed and are unused.

How was this tested?

Unit tests and searching.

@Exempt-Medic Exempt-Medic changed the title Core: Deprecated get_current_option_name and SpecialRange Core: Deprecate get_current_option_name and SpecialRange May 13, 2024
@github-actions github-actions bot added the affects: core Issues/PRs that touch core and may need additional validation. label May 13, 2024
@Exempt-Medic Exempt-Medic changed the title Core: Deprecate get_current_option_name and SpecialRange Core: Remove deprecated get_current_option_name and SpecialRange May 13, 2024
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label May 13, 2024
@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label May 13, 2024
remyjette
remyjette approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@remyjette remyjette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git grep shows these are no longer used in main, tests still pass, and both removals are following the expectations set out in their TODOs for when they will be removed.

lgtm

@Exempt-Medic Exempt-Medic added is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. and removed is: enhancement Issues requesting new features or pull requests implementing new features. labels May 14, 2024
black-sliver
black-sliver approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine

@black-sliver black-sliver merged commit 6d8ac5d into ArchipelagoMW:main May 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyjette remyjette remyjette approved these changes

@black-sliver black-sliver black-sliver approved these changes

Assignees
No one assigned
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Exempt-Medic @remyjette @black-sliver