-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core, CI: Add Python 3.12 support #3290
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stardew changes are totally fine.
Other changes look okay, but my expertise is low so I wouldn't put much weight on that approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a Python 3.12.3 venv in Windows, tested
- Webhost: launching the webhost which didn't work before sending a location, making sure the tracker updated, closing and relaunching the server to validate the load from the savefile. Didn't see any errors in the log, no warnings other than options deprecations
- Generate: Just did a simple clique generate and looked for errors in the log. Didn't see any. Only warnings were again options deprecations.
- Kivy: Ran the launcher, checked the logs for any Kivy errors, didn't see any. Opened the text client, connected to a slot, still didn't see any errors.
|
I think it is still undecided how we are going to handle this exactly once we drop 3.8, but kivy sometimes being slow to update might be a problem regardless of our plans, so I think the versions should be mentioned explicitly. We had a bunch of people that were on unsupported python versions and didn't know. My personal preference would be to roughly follow github ubuntu-latest python for the oldest, which changes around the time when the latest Ubuntu LTS gets its point 1 release. And bleeding edge for the newest. |
What is this fixing or adding?
Add/fix Python 3.12 support. and use 3.12 in CI
Stardew and ModuleUpdate could be cherry-picked if we want to give upstream pony more time.
How was this tested?