Shivers: New features and removes two missed options using the old options API

[GodlFire]

What is this fixing or adding?

Adds the following new features to Shivers:
-Pot pieces can now optionally be found as already completed pots
-Pot pieces can now be chosen where they are located (local/non-local/anywhere)
-The number of Ixupi needed for completion can now be chosen

Removes two uses of the old options API
Adjusts some locations/regions in preparation of room shuffle.
Minor adjustments to Shivers Docs

How was this tested?

Ran several solo and async games on the Shivers Discord:
https://archipelago.gg/room/kr2tniqtSi2d8BnJH8pupg
https://archipelago.gg/room/lUwIijV5TTe6UZNZGyR2kg

If this makes graphical changes, please attach screenshots.

N/A

[Exempt-Medic]

Some small things I noticed quickly

[Exempt-Medic]

Some of these should have their closing """ on a separate line

Suggested change

	- Any World: Pot pieces will be located in any world"""
	- Any World: Pot pieces will be located in any world
	"""

[korydondzila]

Basically like how IxupiCapturesNeeded is written. (the opening """ should be on their own line as well)

[GodlFire]

All options fixed to have """ on their own line for consistency.

[Exempt-Medic]

Suggested change

	- Mixed: Each pot will be randomly chosen to be pieces or already completed."""
	- Mixed: Each pot will be randomly chosen to be pieces or already completed.
	"""

[GodlFire]

All options fixed to have """ on their own line for consistency.

[Exempt-Medic]

Newline at end of file

Suggested change

	}
	}

[GodlFire]

I don't know what the benefit is to having a new line at the end of the file but I have added it.

[Exempt-Medic]

Newline at end of file

Suggested change

	}
	}

[GodlFire]

Added

[Exempt-Medic]

"set in options" is a bit odd, you probably want "their options"

Suggested change

	Victory is achieved when the player has captured the required number Ixupi set in options.
	Victory is achieved when the player has captured the required number Ixupi set in their options.

[GodlFire]

Changed.

[Exempt-Medic]

You might want this link instead

Suggested change

	- [Shivers Randomizer](https://github.com/GodlFire/Shivers-Randomizer-CSharp/releases) Latest release version
	- [Shivers Randomizer](https://github.com/GodlFire/Shivers-Randomizer-CSharp/releases/latest) Latest release version

[GodlFire]

Changed.

[korydondzila]

As far as the logic goes for Shivers this all looks correct to me. (and I have played in a few asyncs with these code changes recently).

[korydondzila]

Missed one

Suggested change

	"""Chooses how keys needed to reach the lobby are placed.
	"""
	Chooses how keys needed to reach the lobby are placed.

[GodlFire]

Fixed.

[Exempt-Medic]

You may want to also change the PuzzleHintsRequired docstring so it formats better, something like:

    """
    If turned on puzzle hints will be available before the corresponding puzzle is required.
    For example: The Shaman Drums puzzle will be placed after access to the security cameras which give you the solution.
    Turning this off allows for greater randomization.
    """

Though this is longer than 120 characters, the options pages ignore that a lot and formatting should probably be prioritized instead.

[GodlFire]

You may want to also change the PuzzleHintsRequired docstring so it formats better, something like:

    """
    If turned on puzzle hints will be available before the corresponding puzzle is required.
    For example: The Shaman Drums puzzle will be placed after access to the security cameras which give you the solution.
    Turning this off allows for greater randomization.
    """

Though this is longer than 120 characters, the options pages ignore that a lot and formatting should probably be prioritized instead.

Agreed. I have also changed the example to one that makes much more sense in a non room shuffle setting.

Before and after: