MLSS: General bugfixes + Add patch extension to inno_setup.iss #3286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
the
is: bug/fix
nicholassaylor
approved these changes
May 13, 2024
github-actions
bot
added
the
affects: core
jamesbrq
changed the title
|
I accidentally used my main branch for this PR when I initially uploaded it, so I just updated the PR title since 2 other small other changes we're made. Nicholas' review is now out of date on this PR. |
Silvris
reviewed
May 17, 2024
nicholassaylor
approved these changes
May 17, 2024
|
Can someone test the setup changes? Easiest is probably running it from the CI build ( https://github.com/ArchipelagoMW/Archipelago/actions/runs/9134849817 ) , which would also test frozen 3.8, which I think we also never test 😓 |
beauxq
approved these changes
May 18, 2024
There was a problem hiding this comment.
- downloaded the Windows Python 3.8 build produced by CI
- installed it
- made the template yamls
- moved
Mario & Luigi Superstar Saga.yamltoPlayers - generated
- double-clicked the patch, and it asked me for my rom
I stopped there because I don't have the game, but it seems to be working to that point.
also skimmed over the code, and don't see any problems
NewSoupVi
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This fixes a GBA bios softlock due to the header of the game being edited.
How was this tested?
The ROM was able to be verified in a fresh game and I could send checks out.
If this makes graphical changes, please attach screenshots.